Request 629477 (accepted)

This request supersedes: request 628574 (Show diff)

Overview

Request 629477 accepted

No description set

Created by jmcdough almost 6 years ago
In state accepted
Supersedes 628574

Submit ldb

Comments for request 629477 0
Comments for request 628574 6

Ismail Dönmez (namtrac) - almost 6 years ago

@jmcdough

This doesn't make sense:

%check
%if %{with_lmdb}
LD_LIBRARY_PATH="bin/shared:bin/shared/private" \
LDB_MODULES_PATH="bin/modules" \
make test
%endif

So you only check if lmdb is enabled?

David Mulder (dmulder) - almost 6 years ago

source maintainer

make test now dies without lmdb enabled. But ldb only builds with lmdb on x86_64 with lmdb >= 0.9.16. So, I agree it doesn't make sense, but someone upstream did this. Disabling %check without lmdb is intentional.

Ismail Dönmez (namtrac) - almost 6 years ago

Ah ok, please add a comment before next SR. I'll accept this as-is now.

Dominique Leuenberger (dimstar) - almost 6 years ago

reviewer

breaks samba:

[  544s] In file included from ../source4/dsdb/common/util.c:27:
[  544s] /usr/include/ldb_module.h:68:2: error: #error "Samba < 4.9 is not compatible with this version of ldb due to assumptions around fork() behaviour"
[  544s]  #error "Samba < 4.9 is not compatible with this version of ldb due to assumptions around fork() behaviour"
[  544s]   ^~~~~
[  545s] Waf: Leaving directory `/home/abuild/rpmbuild/BUILD/samba-4.8.2+git.30.690aa93c189/bin'

David Mulder (dmulder) - almost 6 years ago

source maintainer

Ah, then this submission needs to wait for the samba 4.9 build (which isn't released yet).