Request 627331 (accepted)

This request supersedes: request 626900 (Show diff)

Overview

Request 627331 accepted

No description set

Created by msmeissn almost 6 years ago
In state accepted
Supersedes 626900

Submit libraw

Comments for request 627331 6
Comments for request 626900 2

Dominique Leuenberger (dimstar) - almost 6 years ago

reviewer

Sill needs love on libkdcraw's side of things:

CC @wolfi323 @luca_b @Vogtinator @alarrosa @tittiatcoke @cgiboudeaux

[   75s] /home/abuild/rpmbuild/BUILD/libkdcraw-18.04.3/src/kdcraw_p.cpp: In member function 'bool KDcrawIface::KDcraw::Private::loadFromLibraw(const QString&, QByteArray&, int&, int&, int&)':
[   75s] /home/abuild/rpmbuild/BUILD/libkdcraw-18.04.3/src/kdcraw_p.cpp:377:32: error: 'struct libraw_output_params_t' has no member named 'linenoise'
[   75s]              raw.imgdata.params.linenoise    = m_parent->m_rawDecodingSettings.NRThreshold * 2.11E-5 + 0.00111111;
[   75s]                                 ^~~~~~~~~

Dominique Leuenberger (dimstar) - almost 6 years ago

reviewer

Waiting for libkdcraw fix

Fabian Vogt (favogt) - almost 6 years ago

I had a look - libraw completely removed demosaic packs. Getting it to build again would be trivial, but actually fixing it takes quite a bit of work FWICT.

Wolfgang Bauer (wolfi323) - over 5 years ago

Has been fixed for 18.08.1: https://cgit.kde.org/libkdcraw.git/commit/?id=f40ebe30dca1cfadc8171364ac325532e6c3f229

I'll submit an update with that patch...

Wolfgang Bauer (wolfi323) - over 5 years ago

PS: krita apparently needs to be fixed as well: https://cgit.kde.org/krita.git/commit/?id=3b7d0f2cbf66b06e12c57be26b262b71d8030d1a

Dominique Leuenberger (dimstar_suse) - over 5 years ago

reviewer target maintainer

Unignored: returned to active backlog.

Dominique Leuenberger (dimstar) - almost 6 years ago

reviewer

breaks https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:E/libkdcraw/standard/x86_64

CC @wolfi323 @luca_b @Vogtinator @alarrosa @tittiatcoke @cgiboudeaux

Dominique Leuenberger (dimstar) - almost 6 years ago

reviewer

[  166s] /home/abuild/rpmbuild/BUILD/libkdcraw-18.04.3/src/kdcraw_p.cpp: In member function 'bool KDcrawIface::KDcraw::Private::loadFromLibraw(const QString&, QByteArray&, int&, int&, int&)':
[  166s] /home/abuild/rpmbuild/BUILD/libkdcraw-18.04.3/src/kdcraw_p.cpp:377:32: error: 'struct libraw_output_params_t' has no member named 'linenoise'
[  166s]              raw.imgdata.params.linenoise    = m_parent->m_rawDecodingSettings.NRThreshold * 2.11E-5 + 0.00111111;
[  166s]                                 ^~~~~~~~~