Overview

Request 615201 accepted

- Modernise spec file with spec-cleaner

Loading...

Matej Cepl's avatar

I don't like it. Update-alternatives system is meant for different versions of the same program or packages providing the same replaceable functionality (various versions of java, various daemons providing /usr/sbin/sendmail). This package's unify and unify from wdiff have absolutely nothing common together. Please, don't do this.


Todd R's avatar

I disagree. Although I agree that the situation isn't ideal, changing the upstream name means that, with no explanation, the documentation just doesn't work. The user then has to go searching around to figure out what happened to the executable they thought they were getting.

Especially considering the unify binary from wdiff is marked as experimental, rather than a core piece of functionality from the package, while the unify executable here is the primary purpose of having the package. On the other hand, renaming the wdiff version breaks compatibility with Fedora. So I think this is the less bad of the possible solutions.

Ultimately it is up to the Factory maintainers to decide. If they reject this solution I will change it. But I think it would hurt usability.


Jan Engelhardt's avatar

History is full of such examples — and shows that renaming is fine.

  • "mt" (tape program vs. autoconf checking for a "manifest tool")
  • /usr/bin/ht (ht(e) vs. tex4ht)

...

People got over renames and will continue to get over renames.

For christ sake, all the GNU tools are renamed to g* on some Unix platforms so as to not collide with the real system tools. Didn't hurt anybody in 20+ years.


Adam Majer's avatar

The correct way is rename the binaries so they don't conflict. Update alternatives is not for this.

Also, rename things in documentation and/or at least add a note in README.SUSE that the binary is renamed.


Dominique Leuenberger's avatar

imho, @mcepl is right here. As an 'alternative' I can expect a program with a different implementation, but when throwing the same paramters at it, getting mostly compatible results. anything else is not 'an alternative'

It is definitively not the right way to work around conflicting file name.

And for arguments sake: renaming binaries is explicitly valid, as configure (autoconf) even has a standard parameter for this: %configure --program-prefix=py- just as an example.


Martin Pluskal's avatar

I reverted changes in devel project - sorry for sending such change, I should have been more carefull when reviewing it.


Todd R's avatar

Sorry for the trouble, then, everyone. I have renamed the other package's binary to "unify_quotes" and will supercede the other request as soon as I confirm it is building correctly.

Request History
Martin Pluskal's avatar

pluskalm created request

- Modernise spec file with spec-cleaner


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Jan Engelhardt's avatar

jengelh accepted review


Staging Bot's avatar

staging-bot set openSUSE:Factory:Staging:F as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:F"


Staging Bot's avatar

staging-bot accepted review

Picked openSUSE:Factory:Staging:F


Repo Checker's avatar

repo-checker accepted review

cycle and install check passed


Yuchen Lin's avatar

maxlin_factory changed priority to moderate => important

raising priority for openSUSE:Factory:Staging:F


Saul Goodman's avatar

licensedigger accepted review

ok


Yuchen Lin's avatar

maxlin_factory accepted review

ready to accept


Yuchen Lin's avatar

maxlin_factory approved review

ready to accept


Yuchen Lin's avatar

maxlin_factory accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by