Overview
Request 612421 accepted
- Update to version 0.4.14:
+ Moved expensive backlinks request to page.get_more() and other
minor fixes.
- Changes from version 0.4.13:
+ Support getting backlinks with continuations, and more general
continuation support in wptools.core
- Minor rebase of python-wptools-avoid-reading-readme.patch.
- Drop %%check entirely, tests require network.
- Fix up sed command to remove hashbang: check for a valid
hashbang on the first line of file only and delete a match.
- Created by badshah400
- In state accepted
-
Package maintainer:
badshah400
- Supersedes 612279
That ifpython in check is wrong, just usecpython3 instead of pythob_exec
Ehm, that should be
That %ifpython3 in check is wrong, just use python3 instead of %python_exec
Otherwise, I completely agree with the intention of the comment ;)
And I am a bit anxious about that line 57
sed -i '1d' scripts/wptool.py
SPEC files have nasty tendency to live longer than expected. Wouldn't something like
sed -i '/^#!\/usr\/bin.*python/d' scripts/wptool.py
be a bit more robust (ideal would to combine these two conditions in one command, "if line 1 contains this RE, delete it", but I am not sure how to write it in sed).
Yes, thanks for the suggestions. I will have a new sr soon.
The robust sed @mcepl is suggesting would probably be something like sed -E "1{/^#!\/usr\/bin.*python/d}" which would only match the pattern on the first line of the file.
Request History
badshah400 created request
- Update to version 0.4.14:
+ Moved expensive backlinks request to page.get_more() and other
minor fixes.
- Changes from version 0.4.13:
+ Support getting backlinks with continuations, and more general
continuation support in wptools.core
- Minor rebase of python-wptools-avoid-reading-readme.patch.
- Drop %%check entirely, tests require network.
- Fix up sed command to remove hashbang: check for a valid
hashbang on the first line of file only and delete a match.
mimi_vx accepted request
ok, tests against online service cannot be used in OBS.
@badshah400 next time try to be more polite and simply add to commit why you removing test
??? I don't understand how you could make tests running at all, they are not packaged (https://github.com/siznax/wptools/issues/125, I have provided PR for it as well).
For now let's package it without any %check section, but please add a note about the above-mentioned issue with its URL.
Dude, I just deleted the %check section already in this sr.
The tests won't work anyway because they need network connection to wikipedia.
@mimi_vx Pray point out how I was impolite! And not the person who leads a comment with three question marks! For a change I had already made and DOCUMENTED!!! See this line
Drop %%check entirely, tests require networkin the .changes.