Overview

Request 596999 accepted

I would like to add this new package which helps with the migration from
SuSEfirewall2 to firewalld.

This time tied to python3 as discussed in sr#595722.


Dominique Leuenberger's avatar

+Requires: python

Can we get NEW code using python3 please? PY2 is going EOL


Dominique Leuenberger's avatar

Let alone that RPM should even auto-detect this as the binary installed in /usr/bin/ hopefully has a preamble correctly pointing to /usr/bin/python(3)


Matthias Gerstner's avatar

So "Requires: python" will always refer to python2 then? For me it is just the "canonical python" but if it helps I can change the line to "Requires: python3".

The script itself is python agnostic. Should the shebang then also point to /usr/bin/python3?

Is there a best practices guide somewhere for reference?


Dominique Leuenberger's avatar
  • python is python2 (rpm -q python -> 2.7.14)
  • python3 is python3 )rpm -q python3 -> 3.6.4)

openSUSE decided against /usr/bin/python being a symlink to /usr/bin/python3, in line with python upstream recommendations, see https://www.python.org/dev/peps/pep-0394/

As this is a distro package, the distribution 'decides' which python to use; in this case, yes, the shebang should point to /usr/bin/python3

Request History
Matthias Gerstner's avatar

mgerstner created request

I would like to add this new package which helps with the migration from
SuSEfirewall2 to firewalld.

This time tied to python3 as discussed in sr#595722.


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar_suse added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:67"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked openSUSE:Factory:Staging:adi:67


Dominique Leuenberger's avatar

dimstar accepted review


Repo Checker's avatar

repo-checker accepted review

cycle and install check passed


Staging Bot's avatar

staging-bot accepted review

ready to accept


Staging Bot's avatar

staging-bot approved review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by