Overview
Request History
a_faerber created request
esptool 2.3.1, a tool for ESP8266/ESP32 microcontrollers (depends on flake8-import-order and flake8-future-import)
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
staging-bot added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:116"
staging-bot accepted review
Picked openSUSE:Factory:Staging:adi:116
licensedigger accepted review
ok
repo-checker accepted review
cycle and install check passed
dimstar accepted review
staging-bot accepted review
ready to accept
staging-bot approved review
ready to accept
dimstar_suse accepted request
Accept to openSUSE:Factory
Depends on python-flake8-import-order sr#596734 and python-flake8-future-import sr#596741.
I replied to this on factory but i'll put it here as well
Personally as this package seems to just ship binaries rather then libraries, personally I think it would be better called "esptool" unless there is already an esptool available in another language. I'd also put it in either then electronics or hardware given that by your definition this seems to be "microcontroller tools" rather then a python library.
I would also only ship the python3 version, having a python 2 and python 3 version of the same binary in the repo's doesn't really make sense. If it was a library other python2 applications may still use then maybe. However using singlespec will still make your life easier when we migrate to another python version or interpreter.
Responded on the list: This package follows the Python packaging guidelines on the openSUSE Wiki, including how to package Singlespec executables. python-rpm-macros says: "Packages adhering to the SUSE Python module naming policy are usually called %{flavor}-%{modname}. In some cases, it is only %{modname} though."
Make a
%package -n esptool
then.I already found exiftool living in perl-Image-ExifTool a bit weird.