Overview

Request 585362 accepted

No description set
Loading...

Marcus Rueckert's avatar

Jan ... I will repeat my comments from the submit request to the devel project:

--- nfswatch.changes
+++ nfswatch.changes
@@ -1,0 +2,10 @@
+Sat Mar 10 01:03:28 UTC 2018 - plinnell@opensuse.org
+- update to 4.9.11
+- run spec-cleaner
+- add makefile.patch to fix linking on TW/Leap 15
+- README file converted to utf8·
+- Fix compile issues on Solaris and Linux alpha machines·
+- Add a ChangeLog file·
+- Add TODO note about broken strict aliasing rule
+
+-------------------------------------------------------------------
  1. you should have more informations than just the version number. the README file even has the needed informations
  2. there should be a newline between the date line and the first line of content
  3. self accept is not good.

How could this be accepted here?


Jan Engelhardt's avatar

How could this be accepted here?

"What happens in the develprj stays in the develprj." Basically, comments or decisions made there do not appear in openSUSE:Factory submissions.

As for #1, yes, that seems like a lapse. I will blame the yast people for it, because they put the in-tarball/upstream changes with dashes instead of asterisks too. Sad sad.

Request History
mrdocs's avatar

mrdocs created request


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Staging Bot's avatar

staging-bot added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:57"


Staging Bot's avatar

staging-bot accepted review

Picked openSUSE:Factory:Staging:adi:57


Saul Goodman's avatar

licensedigger accepted review

ok


Jan Engelhardt's avatar

jengelh accepted review


Repo Checker's avatar

repo-checker accepted review

cycle and install check passed


Dominique Leuenberger's avatar

dimstar_suse accepted review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse approved review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by