+gzip -9f man/*8

There is an rpm build root policy in place compressing the man pages into a distro standard format (for now gz, but that could change)

+install -m 644 conf/10-hostinfo.preset %{buildroot}%{_presetdir}

I honestly doubt that this is the correct way to go - I said before that enabling the service is not the package's responsibility

Hiding it away in a file like this won't make me not see it.

Jason Record (jrecord) - about 6 years ago

author

I'm not trying to hide it so you can't see it. It has been there all along. There are MANY requirements to get the package into Factory. I'm fine with that and am trying to get them all flushed out.

---

Dominique Leuenberger (dimstar) - about 6 years ago

reviewer

Good; then I'm sorry I did not mention this one earlier;

I'm actually a bit surprised that this made it into SLE - the requirements are actually aligned when it comes to this kind of things

One more thing:

+Source: %{name}-%{version}.tar.gz

It's not disallowed, but discouraged. Much better would be to have a full URL where to download the tarball, so that things are verifiable/reprodicible.

If it is a git snapshot, it might be an option to look into source services, namley tar_scm (or obs_scm); If you're interested in this, the package openSUSE:Factory/appstream-glib could serve as an example

Jason Record (jrecord) - about 6 years ago

author

I will work on this, but I'm worried the package will not make it into SLE15. So I want the package submitted first, and then work on external sources if that's okay. I reviewed the package, but it is not completely clear what I need to do to my package and my github sources.

---

Dominique Leuenberger (dimstar) - about 6 years ago

reviewer

Sure - as said: 'not forbidden, but discouraged' :)

rpmlint reports:

hostinfo.noarch: W: suse-missing-rclink hostinfo

The fix would be:

ln -sf service %{buildroot}%{_sbindir}/rchostinfo

I am unclear about: 1. I am also uncertain how to start the hostinfo.timer when the rpm is installed. The presets will enable the server and it works after reboot. However, the customer will have to install the rpm and run systemctl start hostinfo.timer to get things going. Can this be done in another way? 2. I have submit request 584519 for the presets now. It enables the hostinfo.timer and hostinfo.service. 3. I also still need a %preun to remove the files from /run/issue.d per description above.