Overview

Request 572983 accepted

- specfile: remove manual manpage build, done by meson
- Fix typographic issues in description.
- add missing group
- run spec-cleaner
- update to version 2
* casync now supports retrieving index and chunk data from sftp:// URLs. (In
addition to the existing ftp://, http:// and https:// support).
* casync will now honour $TMP if it is set, for placing temporary files and
directories.
* casync now saves/restores basic btrfs subvolume information. (Specifically it
will store whether a directory is a subvolume, and whether it has the
read-only bit set.) Control this metadata option with the new
--with=subvolume/--without=subvolume and
--with=subvolume-ro/--without=subvolume-ro switches.
* casync now saves/restores SELinux label information. Control this metadata
option with the new --with=selinux/--without=selinux switches.
* The libgcrypt dependency has been replaced with an OpenSSL dependency, as
that appears to be better supported today, and may be used to generate
SHA512/256 hashes (see below).
* casync now permits selecting the hash function to use with the new --digest=
option. SHA512/256 is now supported in addition to the old SHA256 algorithm,
which continues to be supported. The new default however is SHA512/256, as it
is substantially faster at otherwise equal properties on today's 64bit
processors. In specific environments SHA256 might perform better, hence both
algorithms remain supported. Index files contain information about the hash
algorithm used, hence automatic compatibility is retained.
* casync now permits selecting the compression format to use with the new
option --compression=. In addition to the originally reported xz compression,
gzip and zstd compression are now supported, the latter being the new default
as it provides excellent compression at very high speeds. It's OK to mix
chunks compressed with different algorithms in the same store, but of course
clients downloading them need to be new enough to read chunks in non-xz
formats. Note that the file suffix for compressed chunks changed ".xz" →
".cacnk", as they now may contain either compression, and continuing to use
the ".xz" suffix would be misleading. To retain compatibility with older
casync, the environment variable $CASYNC_COMPRESSED_CHUNK_SUFFIX may be set
to ".xz", to force usage of the old suffix.
* When extracting archives or archive indexes a subset of the metadata stored
in the archive may now be selected to be replayed, using the usual --with=
and --without= options. For example, if an archive containing full metadata
is extracted with --without=privileged only the unprivileged metadata fields
are extracted (i.e. no file ownership, ACLs, SELinux labels, ...).
* After completing an operation statistics about downloaded chunks are now
shown.
* When invoking "casync mkdev" the third parameter may now be an arbitrarily
selected path below /dev which is then created as a symlink to the block
device used, and registered with udev. This means the usual device
enumeration will find the block device under the name picked. Example:
# casync mkdev /somepath/tomy/index-file.caibx /dev/quux
This will expose the block image /somepath/tomy/index-file.caibx as /dev/quux.
- update to version 1
* casync now supports retrieving index and chunk data from sftp:// URLs. (In
addition to the existing ftp://, http:// and https:// support).
* casync will now honour $TMP if it is set, for placing temporary files and
directories.
* casync now saves/restores basic btrfs subvolume information. (Specifically it
will store whether a directory is a subvolume, and whether it has the
read-only bit set.) Control this metadata option with the new
--with=subvolume/--without=subvolume and
--with=subvolume-ro/--without=subvolume-ro switches.
* casync now saves/restores SELinux label information. Control this metadata
option with the new --with=selinux/--without=selinux switches.
* The libgcrypt dependency has been replaced with an OpenSSL dependency, as
that appears to be better supported today, and may be used to generate
SHA512/256 hashes (see below).
* casync now permits selecting the hash function to use with the new --digest=
option. SHA512/256 is now supported in addition to the old SHA256 algorithm,
which continues to be supported. The new default however is SHA512/256, as it
is substantially faster at otherwise equal properties on today's 64bit
processors. In specific environments SHA256 might perform better, hence both
algorithms remain supported. Index files contain information about the hash
algorithm used, hence automatic compatibility is retained.
* casync now permits selecting the compression format to use with the new
option --compression=. In addition to the originally reported xz compression,
gzip and zstd compression are now supported, the latter being the new default
as it provides excellent compression at very high speeds. It's OK to mix
chunks compressed with different algorithms in the same store, but of course
clients downloading them need to be new enough to read chunks in non-xz
formats. Note that the file suffix for compressed chunks changed ".xz" →
".cacnk", as they now may contain either compression, and continuing to use
the ".xz" suffix would be misleading. To retain compatibility with older
casync, the environment variable $CASYNC_COMPRESSED_CHUNK_SUFFIX may be set
to ".xz", to force usage of the old suffix.
* When extracting archives or archive indexes a subset of the metadata stored
in the archive may now be selected to be replayed, using the usual --with=
and --without= options. For example, if an archive containing full metadata
is extracted with --without=privileged only the unprivileged metadata fields
are extracted (i.e. no file ownership, ACLs, SELinux labels, ...).
* After completing an operation statistics about downloaded chunks are now
shown.
* When invoking "casync mkdev" the third parameter may now be an arbitrarily
selected path below /dev which is then created as a symlink to the block
device used, and registered with udev. This means the usual device
enumeration will find the block device under the name picked. Example:
# casync mkdev /somepath/tomy/index-file.caibx /dev/quux
* This will expose the block image /somepath/tomy/index-file.caibx as /dev/quux.
- add a959668782dafbfe469994b14d9c3adaef4e1c34.patch to fix tests on various non-64bit platforms
- initial package
- add pull request 28 as 28.patch to fix the tests for kernels >= 4.11
- add commmit 675e7902e449cc00b0a459a6ec17a0e044ac966b.patch as patch for a manpage

Loading...

Dominique Leuenberger's avatar

Just curious, to understand myself (no reason for decline)

+%if %{with test}
+%check
+export LANG=C.UTF-8
+%{meson_test}
+%endif

Why is the test suite conditionalized (it is running bye default, so that is fine already; which is why I also said no decline reason)

And a small hint here again: export LANG=C.UTF-8 is part of the %meson_test macro; at least on openSUSE (other distros might not have done it, as C.UTF-8 is not even upstream glibc so far)


Sebastian Wagner's avatar
author source maintainer

Why is the test suite conditionalized (it is running bye default, so that is fine already; which is why I also said no decline reason)

As this was part of the py2pack templates I thought that it should be that way. It turned out, it should not be conditionalized... As other reviewers then declined my SRs because of that I got that removed from the py2pack templates finally. And now I remove that from all the packages when I see these macros again.

And a small hint here again: export LANG=C.UTF-8 is part of the %meson_test macro;

Nice, will test that.


Dominique Leuenberger's avatar

For some packages it made sense to disable the test suites, especially when it's really expensive, either in time or by needed dependencies.

Meson is actually a 'good example' for this - where meson itself is built with the test suite disabled, and then a 2nd package done for mesons test suite (which has an insane amount of additional build deps)

as for meson_test:

$ rpm -E %meson_test

    export LANG=C.UTF-8                      

    /usr/bin/ninja test -v -j4 -C build

That's how the macro is defined on openSUSE (the LANG= export is an openSUSE addition, deviating from upstream's original macros)


Dominique Leuenberger's avatar

rpmlint mentiones the missing group: in its own way too:

casync.src: W: non-standard-group Unspecified
casync.x86_64: W: non-standard-group Unspecified

Dominique Leuenberger's avatar
+%meson_build
+sphinx-build -b man doc build/doc

Why do you need to manually build the man pages after? The meson build system contains instructions to do the man pages directly (and the option seems to be enabled by default)


Sebastian Wagner's avatar
author source maintainer

Why do you need to manually build the man pages after? The meson build system contains instructions to do the man pages directly (and the option seems to be enabled by default)

Nice feature, I'll supersede this request.

Request History
Sebastian Wagner's avatar

sebix created request

- specfile: remove manual manpage build, done by meson
- Fix typographic issues in description.
- add missing group
- run spec-cleaner
- update to version 2
* casync now supports retrieving index and chunk data from sftp:// URLs. (In
addition to the existing ftp://, http:// and https:// support).
* casync will now honour $TMP if it is set, for placing temporary files and
directories.
* casync now saves/restores basic btrfs subvolume information. (Specifically it
will store whether a directory is a subvolume, and whether it has the
read-only bit set.) Control this metadata option with the new
--with=subvolume/--without=subvolume and
--with=subvolume-ro/--without=subvolume-ro switches.
* casync now saves/restores SELinux label information. Control this metadata
option with the new --with=selinux/--without=selinux switches.
* The libgcrypt dependency has been replaced with an OpenSSL dependency, as
that appears to be better supported today, and may be used to generate
SHA512/256 hashes (see below).
* casync now permits selecting the hash function to use with the new --digest=
option. SHA512/256 is now supported in addition to the old SHA256 algorithm,
which continues to be supported. The new default however is SHA512/256, as it
is substantially faster at otherwise equal properties on today's 64bit
processors. In specific environments SHA256 might perform better, hence both
algorithms remain supported. Index files contain information about the hash
algorithm used, hence automatic compatibility is retained.
* casync now permits selecting the compression format to use with the new
option --compression=. In addition to the originally reported xz compression,
gzip and zstd compression are now supported, the latter being the new default
as it provides excellent compression at very high speeds. It's OK to mix
chunks compressed with different algorithms in the same store, but of course
clients downloading them need to be new enough to read chunks in non-xz
formats. Note that the file suffix for compressed chunks changed ".xz" →
".cacnk", as they now may contain either compression, and continuing to use
the ".xz" suffix would be misleading. To retain compatibility with older
casync, the environment variable $CASYNC_COMPRESSED_CHUNK_SUFFIX may be set
to ".xz", to force usage of the old suffix.
* When extracting archives or archive indexes a subset of the metadata stored
in the archive may now be selected to be replayed, using the usual --with=
and --without= options. For example, if an archive containing full metadata
is extracted with --without=privileged only the unprivileged metadata fields
are extracted (i.e. no file ownership, ACLs, SELinux labels, ...).
* After completing an operation statistics about downloaded chunks are now
shown.
* When invoking "casync mkdev" the third parameter may now be an arbitrarily
selected path below /dev which is then created as a symlink to the block
device used, and registered with udev. This means the usual device
enumeration will find the block device under the name picked. Example:
# casync mkdev /somepath/tomy/index-file.caibx /dev/quux
This will expose the block image /somepath/tomy/index-file.caibx as /dev/quux.
- update to version 1
* casync now supports retrieving index and chunk data from sftp:// URLs. (In
addition to the existing ftp://, http:// and https:// support).
* casync will now honour $TMP if it is set, for placing temporary files and
directories.
* casync now saves/restores basic btrfs subvolume information. (Specifically it
will store whether a directory is a subvolume, and whether it has the
read-only bit set.) Control this metadata option with the new
--with=subvolume/--without=subvolume and
--with=subvolume-ro/--without=subvolume-ro switches.
* casync now saves/restores SELinux label information. Control this metadata
option with the new --with=selinux/--without=selinux switches.
* The libgcrypt dependency has been replaced with an OpenSSL dependency, as
that appears to be better supported today, and may be used to generate
SHA512/256 hashes (see below).
* casync now permits selecting the hash function to use with the new --digest=
option. SHA512/256 is now supported in addition to the old SHA256 algorithm,
which continues to be supported. The new default however is SHA512/256, as it
is substantially faster at otherwise equal properties on today's 64bit
processors. In specific environments SHA256 might perform better, hence both
algorithms remain supported. Index files contain information about the hash
algorithm used, hence automatic compatibility is retained.
* casync now permits selecting the compression format to use with the new
option --compression=. In addition to the originally reported xz compression,
gzip and zstd compression are now supported, the latter being the new default
as it provides excellent compression at very high speeds. It's OK to mix
chunks compressed with different algorithms in the same store, but of course
clients downloading them need to be new enough to read chunks in non-xz
formats. Note that the file suffix for compressed chunks changed ".xz" →
".cacnk", as they now may contain either compression, and continuing to use
the ".xz" suffix would be misleading. To retain compatibility with older
casync, the environment variable $CASYNC_COMPRESSED_CHUNK_SUFFIX may be set
to ".xz", to force usage of the old suffix.
* When extracting archives or archive indexes a subset of the metadata stored
in the archive may now be selected to be replayed, using the usual --with=
and --without= options. For example, if an archive containing full metadata
is extracted with --without=privileged only the unprivileged metadata fields
are extracted (i.e. no file ownership, ACLs, SELinux labels, ...).
* After completing an operation statistics about downloaded chunks are now
shown.
* When invoking "casync mkdev" the third parameter may now be an arbitrarily
selected path below /dev which is then created as a symlink to the block
device used, and registered with udev. This means the usual device
enumeration will find the block device under the name picked. Example:
# casync mkdev /somepath/tomy/index-file.caibx /dev/quux
* This will expose the block image /somepath/tomy/index-file.caibx as /dev/quux.
- add a959668782dafbfe469994b14d9c3adaef4e1c34.patch to fix tests on various non-64bit platforms
- initial package
- add pull request 28 as 28.patch to fix the tests for kernels >= 4.11
- add commmit 675e7902e449cc00b0a459a6ec17a0e044ac966b.patch as patch for a manpage


Saul Goodman's avatar

licensedigger accepted review

ok


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Staging Bot's avatar

staging-bot added openSUSE:Factory:Staging:adi:14 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:14"


Staging Bot's avatar

staging-bot accepted review

Picked openSUSE:Factory:Staging:adi:14


Repo Checker's avatar

repo-checker accepted review

cycle and install check passed


Dominique Leuenberger's avatar

dimstar accepted review


Staging Bot's avatar

staging-bot accepted review

ready to accept


Staging Bot's avatar

staging-bot approved review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by