Overview
Request 545238 superseded
This package is needed by nodejs-emojione.
- Created by hillwood
- In state superseded
- Superseded by 568580
- Open review for openSUSE:Factory:Staging:adi:10
Request History
hillwood created request
This package is needed by nodejs-emojione.
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
staging-bot added openSUSE:Factory:Staging:adi:10 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:10"
staging-bot accepted review
Picked openSUSE:Factory:Staging:adi:10
repo-checker accepted review
cycle and install check passed
licensedigger accepted review
ok
namtrac added MargueriteSu as a reviewer
Please review.
MargueriteSu accepted review
dimstar declined review
Since comments remain unanswered (at one point): declining
Please do not invent suse_version numbers, they only confuse casual spec file readers and serve nothing.
there has never been a suse_version 1316, so
+%if 0%{?suse_version} < 1315 || 0%{?suse_version} > 1316
is a weird invention and better be
+%if 0%{?suse_version} != 1315
dimstar declined request
Since comments remain unanswered (at one point): declining
Please do not invent suse_version numbers, they only confuse casual spec file readers and serve nothing.
there has never been a suse_version 1316, so
+%if 0%{?suse_version} < 1315 || 0%{?suse_version} > 1316
is a weird invention and better be
+%if 0%{?suse_version} != 1315
superseded by 568580
The build is disabled, so I cannot review the package.
This Building is enable. Please review.
Now at the moment we do not have any npm packages included in the distro, as they were all previously removed after we stopped building npm separately to nodejs.
Apparently the main reason for these two packages (nodejs-underscore, nodejs-emojione) is to build ibus.
@AdamMajer @MargueriteSu, do you think it makes sense to include npm packages separately like in this example or to bundle them because of potential version mismatches with other packages?
Anyway, a little nit (line 20):
%if 0%{?suse_version} >= 1315 || 0%{?suse_version} <= 1316
Is this conditional not always true?
And for line 33, can't those two conditionals be replaced by a single != operator?
@MargueriteSu
@qantas94heavy
Hi, in general, both packages are okay (nodejs-underscore, nodejs-emojione).
they're not packages that required lots of annoying dependencies. they are self-satisfied.
in my opinion, to have or not to have them in factory, matters little with the future of nodejs packaging. because @hillwood manually copy the files in the .tgz tarball, so no matter how packaging changes, they'll stay the same.
to me, they so much look like just two packages accidentally have the prefix "nodejs-" :-)
and they're packages that made ibus full functional. so please let them in.
@hillwood
did you want
here?
No, I mean except 1315 and 1316.
Which version of openSUSE is 1316?
@hillwood that's a good question, what is 1316 refers to ?
1316 = Leap 42.2 and 42.3
Where is that info from?
Leap 42.x is suse_version 1315