Overview
Request History
dimstar created request
Retry to add to TW - the embedded libav code is dropped, we use the system ffmpeg, which passed legal
staging-bot added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:221"
staging-bot accepted review
Picked openSUSE:Factory:Staging:adi:221
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added factory-repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
factory-repo-checker reopened review
Execution plan: multimedia:libs/openSUSE_Tumbleweed
can't install gstreamer-plugins-libav-1.12.2-1.1.x86_64:
nothing provides gstreamer >= 1.12.2 needed by gstreamer-plugins-libav-1.12.2-1.1.x86_64
(we have gstreamer-1.12.1-1.1.x86_64)
mrdocs accepted review
ok
factory-repo-checker accepted review
Builds for repo multimedia:libs/openSUSE_Tumbleweed
namtrac declined review
+# Ensure we cannot use the embedded libav
+rm -rf gst-libs/ext/libav
This needs to be done inside the tarball, like the other repack scripts. Otherwise src.rpm will have tainted code.
namtrac declined request
+# Ensure we cannot use the embedded libav
+rm -rf gst-libs/ext/libav
This needs to be done inside the tarball, like the other repack scripts. Otherwise src.rpm will have tainted code.
dimstar reopened request
The tarball mangling is not done anymore after discussion with legal about those cases - look at -ugly and -bad before you decline based on such an argument please.
mrdocs accepted review
ok
licensedigger declined review
@babelworx declined the legal report with the following comment: PL-3.0+ : Found in 5 files
gst-libav-1.12.2/gst-libs/ext/libav/COPYING.GPLv3
gst-libav-1.12.2/gst-libs/ext/libav/cmdutils.c
gst-libav-1.12.2/gst-libs/ext/libav/compat/solaris/make_sunver.pl
gst-libav-1.12.2/gst-libs/ext/libav/doc/t2h.pm
licensedigger declined request
@babelworx declined the legal report with the following comment: PL-3.0+ : Found in 5 files
gst-libav-1.12.2/gst-libs/ext/libav/COPYING.GPLv3
gst-libav-1.12.2/gst-libs/ext/libav/cmdutils.c
gst-libav-1.12.2/gst-libs/ext/libav/compat/solaris/make_sunver.pl
gst-libav-1.12.2/gst-libs/ext/libav/doc/t2h.pm
dimstar reopened request
The GPL-3.0 files in gst-libs/ext/libav are deleted during the build phase and not used
licensedigger accepted review
ok
staging-bot accepted review
ready to accept
staging-bot approved review
ready to accept
dimstar_suse accepted request
Accept to openSUSE:Factory
It appears from my testing that if this package is in the distribution then ffmpeg supplies all needed codecs and gstreamer doesn't have to come from a community repository.
In other words, still uses embedded libav?
No, obs version built against obs ffmpeg uses any available libavcodec/libavformat.
@namtrac tained how? Assuming it's just a copy of ffmpeg, then note that ffmpeg does not have its source code pre-stripped either.
@babbelworx - as discussed, gst-libs/ext/libav is not used during build - the directory is even deleted in tghe prep phase, right after unpacking the tarball