Overview

Request 239627 accepted

Copy OFED 3.12 packages from SLE12

Loading...
Request History
Philipp Thomas's avatar

psmt created request

Copy OFED 3.12 packages from SLE12


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Factory Auto's avatar

factory-auto added a reviewer

Please review sources


Factory Auto's avatar

factory-auto added a reviewer

Please review build success


Factory Auto's avatar

factory-auto added a reviewer

Pick Staging Project


Saul Goodman's avatar

licensedigger accepted review

{"approve": "preliminary, version number changed"}


Factory Repo Checker's avatar

factory-repo-checker accepted review

Builds for repo OFED:Factory/openSUSE_Factory


Stephan Kulow's avatar

coolo accepted review

No need for staging, not in tested ring projects.


Dominique Leuenberger's avatar

dimstar declined request

And finally, as nobody else looks at my comments, I decline based on those rpmlint warnings that would be easy enough to fix and take serious:

* Optional, but good practice
opensm.i586: W: no-reload-entry /etc/init.d/opensmd
In your init script (/etc/rc.d/init.d/your_file), you don't have a 'reload'
entry, which is necessary for good functionality.

* Service should be stopped on removal;
opensm.i586: W: init-script-without-%stop_on_removal-preun /etc/init.d/opensmd
The init script should have a %preun script that calls %stop_on_removal.

& Service should be restarted on update
opensm.i586: W: init-script-without-%restart_on_update-postun /etc/init.d/opensmd
The package has an init script but is missing the %restart_on_update call in
%postun to automatically restart the daemon. This is optional, but in most
cases it is wanted. Please check.

=> and overall: systemd integration for new packages is strongly encouraged.


Philipp Thomas's avatar

psmt added a reviewer

All the points stated in the last reject are present so I see no reason to not check this in


Philipp Thomas's avatar

psmt added a reviewer

the code works and the package name is the upstream one. These are plugins for libibverbs so the SLPP does not apply


Dominique Leuenberger's avatar

dimstar accepted review

ok


Dominique Leuenberger's avatar

dimstar approved review

ok


Ludwig Nussel's avatar

lnussel accepted request

Accept to factory

openSUSE Build Service is sponsored by