Overview

Request 155558 accepted

Changes in response to -factory ML feedback
Please forward to 12.3 (forwarded request 155557 from RBrownCCB)

Request History
Richard Brown's avatar

RBrownCCB created request

Changes in response to -factory ML feedback
Please forward to 12.3 (forwarded request 155557 from RBrownCCB)


Saul Goodman's avatar

licensedigger accepted review

{"approve": "license and version number unchanged: 12.3"}


Factory Auto's avatar

factory-auto added a reviewer

the package is still building for repository openSUSE_Factory


Factory Auto's avatar

factory-auto added a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Builds for repo openSUSE_Factory


Andreas Jaeger's avatar

a_jaeger declined request

I see a lot of deleted files and the changes message does not indicate
that those should be deleted. Please double check.

for example:
--- gnome/lightrays
+++ gnome/lightrays
-(directory)
Binary files gnome/lightrays/day-1280x1024.jpg deleted
Binary files gnome/lightrays/day-1600x1200.jpg deleted
Binary files gnome/lightrays/day-1920x1080.jpg deleted
Binary files gnome/lightrays/day-1920x1200.jpg deleted
...
Binary files gnome/lightrays/night-1920x1080.jpg deleted
Binary files gnome/lightrays/night-1920x1200.jpg deleted
Binary files grub2/theme/boot_menu_c.png deleted
Binary files grub2/theme/boot_menu_e.png deleted
Binary files grub2/theme/boot_menu_n.png deleted
Binary files grub2/theme/boot_menu_ne.png deleted
Binary files grub2/theme/boot_menu_nw.png deleted
Binary files grub2/theme/boot_menu_s.png deleted
Binary files grub2/theme/boot_menu_se.png deleted
Binary files grub2/theme/boot_menu_sw.png deleted
Binary files grub2/theme/boot_menu_w.png deleted
Binary files grub2/theme/terminal_c.png deleted
Binary files grub2/theme/terminal_e.png deleted
Binary files grub2/theme/terminal_n.png deleted
Binary files grub2/theme/terminal_ne.png deleted
Binary files grub2/theme/terminal_nw.png deleted
Binary files grub2/theme/terminal_s.png deleted
Binary files grub2/theme/terminal_se.png deleted
Binary files grub2/theme/terminal_sw.png deleted
Binary files grub2/theme/terminal_w.png deleted
--- kdm/pics
+++ kdm/pics
-(directory)
--- kdm/pics/.randomlist
+++ kdm/pics/.randomlist
@@ -1 +0,0 @@
-person
Binary files kdm/pics/kdelogo.png deleted
Binary files kdm/pics/shutdown.jpg deleted

Check yourself the deleted lines with
osc rq show -d 155558

If the deletion is fine, please update the changes entry and resubmit.

Andreas


Richard Brown's avatar

RBrownCCB added a reviewer

The notifications of deleted files are incorrect, and were all removed some time ago - eg. lightrays was removed when we split to 12.3, grub2 files were removed with my change of Feb 05 13:59, plymouth files removed on Feb 06 - I dont know what OBS's diff is playing at, but I'm confident the package I've submitted is 'right', re-opening request


Andreas Jaeger's avatar

a_jaeger approved review

if you say so ;)


Andreas Jaeger's avatar

a_jaeger accepted review

if you say so ;)


Stephan Kulow's avatar

coolo accepted request

checkin and copy for 12.3

openSUSE Build Service is sponsored by