Overview
Request History
coolo created request
- fix compilation with newer Mesa in #undefing a new symbol
ClanLib-2.3.6-fix-opengl.patch
jreidinger added a reviewer
Hi, thanks for the patch. Could you please provide where you upstream patch?
I see there problem with possible conflict of types if definition differs and someone include first opengl1_defines and then mesa, it also cause problems for him. Maybe it will be better if type is already defined to not redefine it and just use Mesa one.
coolo approved review
-upstream means fixed that are not opensuse specific
jreidinger accepted request
Well, I am still not really convince if this is right approach, as these two values differs, so when something relies on value provided by mesa, then when start using clanlib it will be no longer available and contain different value. It is one of C define pain. Let's hope upstream solve it better ( like rename in clanlib its enum value, but on other it breaks backward compatibility ).
coolo accepted review
-upstream means fixed that are not opensuse specific
