Loading...
Login required, please
login
in order to comment
Request History
Dmitry_R created request
dimstar approved review
Quick review:
- Generally speaking, this is ok... there are a few comments only:
- Source of the .desktop file? Adding the source as comment might help. If it's planned to be merged with upstream, a check that we don't ever overwrite the upstream variant would be welcome. The same of the .png.
dimstar accepted request
checkin
dimstar accepted review
Quick review:
- Generally speaking, this is ok... there are a few comments only:
- Source of the .desktop file? Adding the source as comment might help. If it's planned to be merged with upstream, a check that we don't ever overwrite the upstream variant would be welcome. The same of the .png.
