Overview

Request 127042 superseded

Please review, dependency for libee and rsyslog v6-stable 6.2.2 (home:AndreasStieger:rsyslog:v6-stable for Base:System)

Loading...
Request History
Andreas Stieger's avatar

AndreasStieger created request

Please review, dependency for libee and rsyslog v6-stable 6.2.2 (home:AndreasStieger:rsyslog:v6-stable for Base:System)


Saul Goodman's avatar

licensedigger added a reviewer

{"delegate": "new package r>3"}


Factory Auto's avatar

factory-auto added a reviewer

Please review sources


Andreas Jaeger's avatar

a_jaeger declined request

I don't think this is needed at all and suggest to remove it.
After running ldconfig everything should be fine.
And even without ldconfig everything should work.

If it's needed, please explain why.
+# update lib.so to point to the lib moved to /usr/lib[64]
+%{__ln_s} -fv /%{_libdir}/$(readlink %{buildroot}/%{_libdir}/%{name}.so) \
+ %{buildroot}%{_libdir}/%{name}.so

The rest looks fine, thanks.


Andreas Stieger's avatar

AndreasStieger superseded request

Superseded by request 127686


Saul Goodman's avatar

licensedigger accepted review

{"delegate": "new package r>3"}


Factory Auto's avatar

factory-auto accepted review

Builds for repo openSUSE_Factory


Andreas Jaeger's avatar

a_jaeger declined review

I don't think this is needed at all and suggest to remove it.
After running ldconfig everything should be fine.
And even without ldconfig everything should work.

If it's needed, please explain why.
+# update lib.so to point to the lib moved to /usr/lib[64]
+%{__ln_s} -fv /%{_libdir}/$(readlink %{buildroot}/%{_libdir}/%{name}.so) \
+ %{buildroot}%{_libdir}/%{name}.so

The rest looks fine, thanks.

openSUSE Build Service is sponsored by