Overview

Request 122630 accepted

- STRLEN has 64 bits here and int has 32, so the (int*) cast in
XML::LibXML::Document::toStringHTML() makes htmlDocDumpMemory() store
the 32-bit length of the result into a 64-bit variable. Depending on
the endianness, it either works OK (LE) or corrupts the variable (BE)
Just use an 'int' instead, and cast it to an STRLEN later in the
newSVpvn() call. (forwarded request 122259 from k0da)

Request History
Marcus Meissner's avatar

msmeissn created request

- STRLEN has 64 bits here and int has 32, so the (int*) cast in
XML::LibXML::Document::toStringHTML() makes htmlDocDumpMemory() store
the 32-bit length of the result into a 64-bit variable. Depending on
the endianness, it either works OK (LE) or corrupts the variable (BE)
Just use an 'int' instead, and cast it to an STRLEN later in the
newSVpvn() call. (forwarded request 122259 from k0da)


Factory Auto's avatar

factory-auto added a reviewer

Please review sources


Ruediger Oertel's avatar

oertel approved review

reviewed by ro


Stephan Kulow's avatar

coolo accepted request

checkin


Saul Goodman's avatar

licensedigger accepted review

{"approve": "license and version number unchanged: 1.95"}


Factory Auto's avatar

factory-auto accepted review

Builds for repo pure_factory


Ruediger Oertel's avatar

oertel accepted review

reviewed by ro

openSUSE Build Service is sponsored by