Overview
Request 1175473 accepted
- If ffmpeg_pref is defined, use it, otherwise use ffmpeg-6 or
ffmpeg-4 depening on suse_version.
- Build with ffmpeg-6 in TW and ffmpeg-4 in Leap
- Created by mcalabkova
- In state accepted
- Supersedes 1174863
Inline comment for target: 'openSUSE:Factory/python-pydub', file: 'python-pydub.spec', and line: 6.
openSUSE:Factory prjconf defines ffmpeg_pref already. Can we rely on the defined one if existing, and only define to anything else if not pre-defined?
I submitted https://build.opensuse.org/request/show/1175333 following your suggestion but I don't think ffmpeg_pref is really defined in Factory since it doesn't appear inside a Macros: section, right? I did some tests in my home project, and just using %define ffmpeg_pref in the prjconf wasn't enough to have that macro defined in the spec file
We'll add it into the macros section too in this case. Makes most sense
Inline comment for target: 'openSUSE:Factory/python-pydub', file: 'python-pydub.spec', and line: 20.
Why the conflict with mini? Do you really need all codecs during build?
yes, the tests fail if ffmpeg-mini-libs is installed instead of the real ffmpeg libs.
Request History
mcalabkova created request
- If ffmpeg_pref is defined, use it, otherwise use ffmpeg-6 or
ffmpeg-4 depening on suse_version.
- Build with ffmpeg-6 in TW and ffmpeg-4 in Leap
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
dimstar accepted review
licensedigger accepted review
ok
anag+factory added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:68"
anag+factory accepted review
Picked "openSUSE:Factory:Staging:adi:68"
anag+factory accepted review
Staging Project openSUSE:Factory:Staging:adi:68 got accepted.
anag+factory approved review
Staging Project openSUSE:Factory:Staging:adi:68 got accepted.
anag+factory accepted request
Staging Project openSUSE:Factory:Staging:adi:68 got accepted.