Overview

Request 1157097 accepted

mention additional -devel package dependencies added in changelog

Loading...

Dominique Leuenberger's avatar
%check
export TESTSUITEFLAGS='-v -j128'
%make_build check || /bin/true
[ -f ./tests/testsuite.log ] || echo "check did not run" > ./tests/testsuite.log
mkdir $RPM_BUILD_ROOT/%{_datadir}/pspp/tests
# remove nondeterministic bits to make package build reproducible:
perl -i -pe '
  s/ (starting|ending) at:.*/ $1 at: [scrubbed]/;
  s/(test suite duration:).*/$1 [scrubbed]/;
  s/(hostname =) .*/$1 [hostscrubbed]/;
  s/^(\| on) [a-zA-Z0-9._-]+/$1 [hostscrubbed]/;
  s/ \(\d+m.*\ds\)/([durationscrubbed])/;
  s/20\d\d-\d\d-\d\d \d\d:\d\d:\d\d\.\d+ [+-]\d\d00/[datescrubbed]/;
  s!(bin/ld: /tmp/conftest\.)\w+!$1[randomnessscrubbed]!;
  s!^(\| \./configure: line \d+: *)\d+ (Aborted)!$1 [PIDscrubbed] $2!;
' ./tests/testsuite.log
cp ./tests/testsuite.log $RPM_BUILD_ROOT/%{_datadir}/pspp/tests/

%check is not supposed to modify %{buildroot} (old error - won't decline for it today)


Mindaugas Baranauskas's avatar

moving mentions of $RPM_BUILD_ROOT outside %check is enough?


Dominique Leuenberger's avatar

depending what they do, yes.. .basically you should ensure that %check only READS, but does not write anything into %buildroot (otherwise the package build differed between check enabler or disabled)


Mindaugas Baranauskas's avatar

actually It writes to disk test results, thus maybe it is ok to clear "%check" line, but execute remaining part?


Dominique Leuenberger's avatar

that does not sound like relevant data to ship to all user disks -I'd simply not write that log to %buildroot



Marcus Rueckert's avatar

your documentation changes also required all the new build requires?


Mindaugas Baranauskas's avatar

Actually no, not related to documentation, just adding few automatically suggested dependencies to -devel package to remove warning at end of build about probably missing dependencies dependencies

Request History
Mindaugas Baranauskas's avatar

embar created request

mention additional -devel package dependencies added in changelog


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Staging Bot's avatar

staging-bot added openSUSE:Factory:Staging:adi:7 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:7"


Staging Bot's avatar

staging-bot accepted review

Picked "openSUSE:Factory:Staging:adi:7"


Dominique Leuenberger's avatar

dimstar accepted review


Ana Guerrero's avatar

anag+factory accepted review

Staging Project openSUSE:Factory:Staging:adi:7 got accepted.


Ana Guerrero's avatar

anag+factory approved review

Staging Project openSUSE:Factory:Staging:adi:7 got accepted.


Ana Guerrero's avatar

anag+factory accepted request

Staging Project openSUSE:Factory:Staging:adi:7 got accepted.

openSUSE Build Service is sponsored by