Overview
Request History
13ilya created request
- Changed file dosbox-staging-config.patch.
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
staging-bot added openSUSE:Factory:Staging:adi:10 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:10"
staging-bot accepted review
Picked "openSUSE:Factory:Staging:adi:10"
dimstar accepted review
anag+factory accepted review
Staging Project openSUSE:Factory:Staging:adi:10 got accepted.
anag+factory approved review
Staging Project openSUSE:Factory:Staging:adi:10 got accepted.
anag+factory accepted request
Staging Project openSUSE:Factory:Staging:adi:10 got accepted.
mrueckert wrote (1146987) (https://build.opensuse.org/request/show/1146987) any reason why you disable crt filter? it was supposed to be one of the big features of the new release
https://www.gamingonlinux.com/2024/02/dosbox-staging-0-81-0-out-now-with-new-crt-shaders-and-lots-of-graphics-improvements/
This is not consistent with reality.
1 Most users don't need to emulate old monitors, scanlines, noise interference and other garbage that users had 30 years ago! Shader crt-auto that they made by default just and emulates scanlines and blur, I did not like it very much!
2 Shader sets vga-* For example vga-1080p are tied to screen resolution and cannot be set by default.
3 I compared vga-1080p shader and sharpю I like sharp better and it is universal.
4 mednafen has a shader sabr which is perfect for me, it smooths pixels perfectly and makes the image sharper, unfortunately dosbox-staging doesn't have it.
So I'm left with my opinion to keep sharp by default as the best available and universal.
This won't fly. Users expect a package to behave the same way as upstream, unless there is a damn good reason to deviate. Personal preference do not qualify as a good reason.
So if upstream broke it, and from my point of view he broke it, then this broken shader I should upload to other users?
Should I also remove the name-patch so that it's not clear whether it's dosbox or dosbox-staging just because upstream wants it that way?
actually: the argument is perfect! Our package maintainers are not supposed to deliver bad decisions from upstream but make things behave properly in openSUSE.
In general I would agree; but visual modifications have their special place, so much so that we have all those *-branding-{SLE,openSUSE,upstream} packages in openSUSE.