Overview
Request 113686 accepted
tested under openSUSE 12.1
- Created by Mailaender
- In state accepted
- Package maintainer: Mailaender
Loading...
Login required, please
login
in order to comment
Request History
Mailaender created request
tested under openSUSE 12.1
RedDwarf accepted request
I don't see anything to decline it but:
- It would be better if the source tag contained the full URL
- There seems to be no reason to require/use all the autotools
- The setup line doesn't need the explicit "-n"
- It would be better to use a parallel build
- We don't delete the build root at the start of %install
- suse_update_desktop_file is deprecated
- What's that "%define date" for?
- We put the changelog in a .changes file