Overview

Request 1133267 accepted

No description set
Loading...

Dominique Leuenberger's avatar

suse_version > 1600? so NOT for ALP? That sounds weird


Dominique Leuenberger's avatar
# Use the latest supported LLVM version, but Leap only has a slightly older one
# so just use whatever version is available.
%if 0%{?suse_version} > 1600 || 0%{?sle_version} > 150500
%define llvm_major_version 17
%else
%define llvm_major_version %{nil}
%endif

That does not exactly do what is advertised. For Tumbleweed, this picks 'llvm_major_version 17(i.e suse_version 1699); on ALP, it picks%nil` (suse_version == 1600); on Leap 15.4/15.5, it picks %nil if ever rebuilt, on 15.6 it picks 17.

it 'works' (as 17 is latest at the moment) - but likely this should need some rethinking


Shung-Hsi Yu's avatar
author source maintainer

suse_version > 1600? so NOT for ALP? That sounds weird

@dimstar thanks for pointing that out, my mistake. ALP and Tumbleweed indeed should both get LLVM version pinned since both is rolling. While on Leap it should use the default LLVM (hopefully that will be new enough).

Will submit SR to fix this.

Request History
Shung-Hsi Yu's avatar

shunghsiyu created request


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Staging Bot's avatar

staging-bot added openSUSE:Factory:Staging:adi:33 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:33"


Staging Bot's avatar

staging-bot accepted review

Picked "openSUSE:Factory:Staging:adi:33"


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar accepted review


Ana Guerrero's avatar

anag+factory accepted review

Staging Project openSUSE:Factory:Staging:adi:33 got accepted.


Ana Guerrero's avatar

anag+factory approved review

Staging Project openSUSE:Factory:Staging:adi:33 got accepted.


Ana Guerrero's avatar

anag+factory accepted request

Staging Project openSUSE:Factory:Staging:adi:33 got accepted.

openSUSE Build Service is sponsored by