Request 1123261 (accepted)

This request supersedes: request 1123155 (Show diff)

Overview

Request 1123261 accepted

- Remove move of config files to /usr/etc. Sioyek never has code to
read configs in that directory.
- add config as well to /etc. seems to break things if not
- add patch define-linux-standard-paths.patch. using `sed` is very brittle to use
- add env var CONFIG+=non_portable

Created by uncomfyhalomacro 6 months ago
In state accepted
Supersedes 1123155

Submit sioyek

Comments for request 1123261 0
Comments for request 1123155 1

Dominique Leuenberger (dimstar) - 6 months ago

Is the code even reading config files from there? Considering that you had to re-add the config in /etc, I'd assume 'no'?

Soc Virnyl Estela (uncomfyhalomacro) - 6 months ago

yep. it cannot read it at /usr/etc despite the script provided from the source build-linux.sh having $PREFIX/etc.

Soc Virnyl Estela (uncomfyhalomacro) - 6 months ago

it seems to me, that install step was incomplete hence why i found many distros e.g. NixOS, Arch, copies the files instead of using make install 🙃

Dominique Leuenberger (dimstar) - 6 months ago

if it ignores files in /usr/etc, we should probably not copy them there.

just moving files there is never the goal - the UsrEtc move takes more effort, as the code needs to check etc for admin config and fallback to usr/etc for default config... Simply moving to usr and expecting the admin to change files there is even wronger than having the files in etc

Soc Virnyl Estela (uncomfyhalomacro) - 6 months ago

author source maintainer

alright. i will supersede this SR then. in a bit