Overview

Request 1112167 accepted

No description set
Loading...

Dominique Leuenberger's avatar

Inline comment for target: 'openSUSE:Factory/mokutil', file: 'mokutil.changes', and line: 6.

My recommendation:

Add that JSC# to the 'Update to version 0.6.0 line in the changelog entry - not adding a new entry'


Dominique Leuenberger's avatar

Inline comment for target: 'openSUSE:Factory/mokutil', file: 'mokutil.changes', and line: 9.

That patch is already mentioned as being removed as part of the update to version 0.6.0 - should not be needed here


Dominique Leuenberger's avatar

Inline comment for target: 'openSUSE:Factory/mokutil', file: 'mokutil.changes', and line: 11.

That patch was never part of Factory - and the bug reference was never added. Sounds like a Factory First violation.

If this bug is indeed fixed, try to find the version update addressing it and add the bsc# ref at the relevant point


Dominique Leuenberger's avatar

mention the 'dropped patch' as part of the SR -m 'xxx' message when submitting to SLE


Dominique Leuenberger's avatar

Inline comment for target: 'openSUSE:Factory/mokutil', file: 'mokutil.changes', and line: 13.

Same info as for mokutil-enable-setting-fallback-verbosity-and-norebo.patch: add the bsc# ref to the relevant version update information in the changelog. Mention the patch removal as part of the SR message (i.e the patch was never added according to the changelog - mentioning it as being removed makes for an inconsistent history in the master package)


Marcus Rueckert's avatar

mrueckert wrote (1112167) This wouldnt be needed if you follow

https://en.opensuse.org/openSUSE:Howto_Submit_from_Tumbleweed_to_SLES


Joey Lee's avatar
author source maintainer

I have sent out submitreq sr#308671 on IBS. But the changelog bsc#1198458 is still be overwritten by changelog from factory. I don't know how to keep them in changelog on IBS even I followed your URL.


Marcus Rueckert's avatar

you would do one submitrequest message that explains that you switch the branch and explain that you verified that all issue reference lost are still fixed. also mention dropped patches.


Joey Lee's avatar
author source maintainer

Normally I use the following command to submit package from Factory to SLE:

osc sr openSUSE.org:openSUSE:Factory mokutil SUSE:SLE-15-SP6:GA -m "Update to mokutil 0.6.0 (jsc#PED-6528)"

Do you mean that I put all information in the "-m" description? Or how to put a big information block when sending package to SLE?

On the other hand, does "-m" message will be put in changelog? If NOT, how does user find those lost bsc# or Jira# number from changelog?

Request History
Joey Lee's avatar

joeyli created request


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

skipping the staging process since only .changes modifications


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Ruediger Oertel's avatar

oertel accepted review

Accepted review for by_group opensuse-review-team request 1112167 from user factory-auto


Ruediger Oertel's avatar

oertel approved review

Accepted review for by_group opensuse-review-team request 1112167 from user factory-auto


Ana Guerrero's avatar

anag+factory accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by