Request 1108961: Submit pipewire-module-xrdp

Overview

Request 1108961 accepted

Sound doesn't not work in xrdp when using pipewire w/o this module. It has been requested on the Factory mailing list.

Created by jacraig 8 months ago
In state accepted

Submit pipewire-module-xrdp

Comments for request 1108961 7

Staging Bot (staging-bot) - 8 months ago

reviewer

@jacraig, @yfjiang, @yudaike: review reminder

Jason Craig (jacraig) - 8 months ago

author source maintainer

I've never submitted a new package to factory. Am I supposed to review something? If so, what?

Joe S (JoeS) - 8 months ago

Hi Jason,

You've already done more than I know how to do ( THANKS ) but it is confusing because that staging-bot message above seems to indicate it is looking for a review, as does the status above but on the request history on the right it says darix accepted review 4 days ago.

20230908 is compiling now but I suspect that something needs to be done here to change the "review" status to accept but I don't know what it is.

Jan Engelhardt (jengelh) - 8 months ago

reviewer

Reviews are requested from 6 different entities, which includes something like 3 bots/scripts for automated checks, 1 human to help look for package problems that were not autodetected, 1 human that is the maintainer of the submission target (Factory), and, most importantly for this case (and the reason a notification was sent):

1 package maintainer, because whoever submitted the package was not the maintainer itself.

Joe S (JoeS) - 8 months ago

Hi Jengelh,

As per this message from bug 1214295 from Yifan Jiang, Jason was supposed to be added as a maintainer ( he was the submitter )

Hi Jason, Daike, thank you for helping out! I 
have put your name as maintainers
in the package, please check "osc maintainer 
X11:RemoteDesktop
pipewire-module-xrdp" for more details.

Here's the bug report referenced:

https://bugzilla.suse.com/show_bug.cgi?id=1214295#c23

But Jason is unsure what he needs to do to pass the review.

Possibly you could explain what he needs to do?

Thanks!

Jan Engelhardt (jengelh) - 8 months ago

reviewer

click on Approve below this text field

Joe S (JoeS) - 8 months ago

The only Approve on this web page is the Approve text in your reply.

I assume that it only appears for the maintainers so Jason would have to do that but based on his reply I don't think he will see it either.