Overview

Request 1108481 accepted

Update to 5.15.15 (forwarded request 1108449 from krop)



Marcus Rueckert's avatar

mrueckert wrote (1101063) shouldnt this get that a provides for the bundled library?


Christophe Marin's avatar

No need, it's only used internally


Andreas Stieger's avatar

I don't think internal usage matters. We have https://en.opensuse.org/openSUSE:Bundled_software_policy but in the case of chromium this is a nightmare.

Let's dive in: https://github.com/qt/qtwebengine/tree/v5.15.14-lts/src references https://github.com/qt/qtwebengine-chromium/blame/18c9261dc5b8aa57a0bdd5b62ce6f648cca1ef5e/chromium/DEPS#L1355 which is " Chromium to 87.0.4280.67" with re2 as of 25486195537d234bff9e6d785add3eaabe249eb9. According to https://github.com/google/re2/commit/25486195537d234bff9e6d785add3eaabe249eb9 this is re2 2020-10-01.

So that's the version we could add. But I would ask if we are enforcing this universally, and if this package shouldn't be dropped by virtue of bundling a years old chromium.


Christophe Marin's avatar

This is not chromium. It's qtwebengine-chromium (https://code.qt.io/cgit/qt/qtwebengine-chromium.git/log/?h=87-based)

'Provides' doesn't make any sense.


Andreas Stieger's avatar

It is a feasible mechanism to track this kind of stuff. It may not make a lot of sense because we don't strictly enforce it. https://en.opensuse.org/openSUSE:Bundled_software_policy https://docs.fedoraproject.org/en-US/fesco/Bundled_Software_policy/


Andreas Stieger's avatar

The maintainer rejected SR#1101188

Either we accept this one as is, or this package will stand in the way of a re2+chromium security update for the next Chromium major version


Request History
Fabian Vogt's avatar

Vogtinator created request

Update to 5.15.15 (forwarded request 1108449 from krop)


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Ana Guerrero's avatar

anag+factory set openSUSE:Factory:Staging:E as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:E"


Ana Guerrero's avatar

anag+factory accepted review

Picked "openSUSE:Factory:Staging:E"


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:E got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:E got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:E got accepted.

openSUSE Build Service is sponsored by