Overview

Request 1104487 accepted

- Revert Use make for building as specified in the upstream
README.md. Go applications typically need only a few lines for
their go build command. Keeping that listing in the .spec makes
it easier for mainainers to review relevant changes and normalize
to our build conventions. Makefiles for Go applications are often
building docker images and other steps not relevant to distro
packaging, or that may not work inside OBS e.g. network access. (forwarded request 1104486 from jfkw)

Loading...
Request History
Jeff Kowalczyk's avatar

jfkw created request

- Revert Use make for building as specified in the upstream
README.md. Go applications typically need only a few lines for
their go build command. Keeping that listing in the .spec makes
it easier for mainainers to review relevant changes and normalize
to our build conventions. Makefiles for Go applications are often
building docker images and other steps not relevant to distro
packaging, or that may not work inside OBS e.g. network access. (forwarded request 1104486 from jfkw)


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Staging Bot's avatar

staging-bot added openSUSE:Factory:Staging:adi:6 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:6"


Staging Bot's avatar

staging-bot accepted review

Picked "openSUSE:Factory:Staging:adi:6"


Dominique Leuenberger's avatar

dimstar accepted review


Ana Guerrero's avatar

anag+factory accepted review

Staging Project openSUSE:Factory:Staging:adi:6 got accepted.


Ana Guerrero's avatar

anag+factory approved review

Staging Project openSUSE:Factory:Staging:adi:6 got accepted.


Ana Guerrero's avatar

anag+factory accepted request

Staging Project openSUSE:Factory:Staging:adi:6 got accepted.

openSUSE Build Service is sponsored by