Overview
105+%defattr(-,root,root,755)
106+%dir %{_libqt5_archdatadir}
Not needed
The source is not verified by either full download URL or keyring.
What do you mean by "verified"? I see no difference here from my other factory package. The source archive is part of the repository si it is "verified" by the integrity of the repository here on OBS.
That's not enough, we validate that the sources from upstream are unmodified. This is only possible with a GPG keyring or the full source URL.
How does the validation work? There are definitely packages in Factory/Leap that do not have any such mechanisms. If that shall work automatically, than it is broken - the check does not work and you even do not get any related RPM lint warnings.
Is something like:
Url: https://github.com/tumic0/GPXSee/archive/refs/tags/13.4.tar.gz
what you expect to be in the spec file that you call the "full URL validation"?
The source validator bot does the check, not rpmlint.
You can use
Source0: https://github.com/tumic0/QtPBFImagePlugin/archive/%{version}/QtPBFImagePlugin-%{version}.tar.gz
Build fails because it does not build against protobuf correctly. It has to take cmake and/or pkg-config into account.
I have patched the qmake file to use pkg-config to compile under factory, however I think this is rather a factory bug that it does not work with the "standard" linking as this works on all other distros and worked/works even in OpenSuse 15.4...
It's not a factory bug. On older distros it works only by accident because protobuf does not have any other indirect deps.
That's definitely not true. On my archlinux it works fine with the current libprotobuf-lite.so that has the same absl dependency. The linker finds this dependency as expected when the so is used.
Might be some downstream hack. Using just -lprotobuf-lite is definitely wrong.
I really do not think so. Transitive dependencies used to work for ages for me in standard linux distros. There may be some special ld/gcc setup (e.g. some "special" or missing RPATH) in OpenSuse now, but the standard is IMHO the opposite.
The issue is that the code generated by protobuf now references abseil, so it's the application itself which has to build against it, not just the protobuf lib.
Request History
tumic created request
Mapbox vector tiles image plugin for Qt. Used by (but not limited to) GPXSee.
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
staging-bot added openSUSE:Factory:Staging:adi:23 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:23"
staging-bot accepted review
Picked "openSUSE:Factory:Staging:adi:23"
darix accepted review
Accepted review for by_group opensuse-review-team request 1100925 from user staging-bot
anag+factory accepted review
Staging Project openSUSE:Factory:Staging:adi:23 got accepted.
anag+factory approved review
Staging Project openSUSE:Factory:Staging:adi:23 got accepted.
anag+factory accepted request
Staging Project openSUSE:Factory:Staging:adi:23 got accepted.
