Request 1088744 (accepted)

This request supersedes: request 1088721 (Show diff)

Overview

Request 1088744 accepted

Superseding after 1088742

Created by sbradnick 12 months ago
In state accepted
Supersedes 1088721

Submit ms-gsl

Comments for request 1088744 3

Ana Guerrero (anag+factory) - 12 months ago

reviewer

@sbradnick Hi! out of curiosity, why you don't run the tests? Are they too long or there is any other reason?

Scott Bradnick (sbradnick) - 12 months ago

author source maintainer

The -DGSL_TEST=OFF part? That's how it was in the project I based this submission off of and it worked fine for the package which needs ms-gsl to build.

Though I'm not sure what it's really buying me, maybe I could do something like this?

abuild@obs-buildhost:~/rpmbuild/SOURCES>  tar zxf ms-gsl-4.0.0.tar.gz
abuild@obs-buildhost:~/rpmbuild/SOURCES>  ls -l
total 64
drwxr-xr-x 1 abuild abuild   338 Jan 28  2022 GSL-4.0.0
-rw-r--r-- 1 abuild abuild 55846 May 14 16:48 ms-gsl-4.0.0.tar.gz
-rw-r--r-- 1 abuild abuild   477 May 23 23:38 ms-gsl.changes
-rw-r--r-- 1 abuild abuild  2326 May 25 12:22 ms-gsl.spec
abuild@obs-buildhost:~/rpmbuild/SOURCES>  cd GSL-4.0.0/
abuild@obs-buildhost:~/rpmbuild/SOURCES/GSL-4.0.0>  mkdir build-x86
abuild@obs-buildhost:~/rpmbuild/SOURCES/GSL-4.0.0>  cd build-x86/
abuild@obs-buildhost:~/rpmbuild/SOURCES/GSL-4.0.0/build-x86>  cmake ~/rpmbuild/SOURCES/GSL-4.0.0
-- The CXX compiler identification is GNU 13.0.1
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /usr/bin/pkg-config (found version "1.8.0")
-- Checking for one of the modules 'gtest_main'
-- Configuring done (0.2s)
-- Generating done (0.0s)
-- Build files have been written to: /home/abuild/rpmbuild/SOURCES/GSL-4.0.0/build-x86
abuild@obs-buildhost:~/rpmbuild/SOURCES/GSL-4.0.0/build-x86>  cmake --build . --config Release
[  6%] Building CXX object tests/CMakeFiles/gsl_tests.dir/algorithm_tests.cpp.o
[ 13%] Building CXX object tests/CMakeFiles/gsl_tests.dir/assertion_tests.cpp.o
[ 20%] Building CXX object tests/CMakeFiles/gsl_tests.dir/at_tests.cpp.o
[ 26%] Building CXX object tests/CMakeFiles/gsl_tests.dir/byte_tests.cpp.o
[ 33%] Building CXX object tests/CMakeFiles/gsl_tests.dir/notnull_tests.cpp.o
[ 40%] Building CXX object tests/CMakeFiles/gsl_tests.dir/owner_tests.cpp.o
[ 46%] Building CXX object tests/CMakeFiles/gsl_tests.dir/span_compatibility_tests.cpp.o
[ 53%] Building CXX object tests/CMakeFiles/gsl_tests.dir/span_ext_tests.cpp.o
[ 60%] Building CXX object tests/CMakeFiles/gsl_tests.dir/span_tests.cpp.o
[ 66%] Building CXX object tests/CMakeFiles/gsl_tests.dir/strict_notnull_tests.cpp.o
[ 73%] Building CXX object tests/CMakeFiles/gsl_tests.dir/string_span_tests.cpp.o
[ 80%] Building CXX object tests/CMakeFiles/gsl_tests.dir/utils_tests.cpp.o
[ 86%] Linking CXX executable gsl_tests
[ 86%] Built target gsl_tests
[ 93%] Building CXX object tests/CMakeFiles/gsl_noexcept_tests.dir/no_exception_ensure_tests.cpp.o
[100%] Linking CXX executable gsl_noexcept_tests
[100%] Built target gsl_noexcept_tests
abuild@obs-buildhost:~/rpmbuild/SOURCES/GSL-4.0.0/build-x86>  ctest -C Release
Test project /home/abuild/rpmbuild/SOURCES/GSL-4.0.0/build-x86
    Start 1: gsl_tests
1/2 Test #1: gsl_tests ........................   Passed    6.23 sec
    Start 2: gsl_noexcept_tests
2/2 Test #2: gsl_noexcept_tests ...............   Passed    0.00 sec

100% tests passed, 0 tests failed out of 2

Total Test time (real) =   6.23 sec
abuild@obs-buildhost:~/rpmbuild/SOURCES/GSL-4.0.0/build-x86>

Scott Bradnick (sbradnick) - 12 months ago

author source maintainer

I set -DGSL_TEST=ON and added: