Overview
Request 1082659 superseded
- drop python 2 support
- added patches
fix https://github.com/beetbox/mediafile/issues/68
+ python-mediafile-pyupgrade.patch
- Created by pgajdos
- In state superseded
- Supersedes 1082643
- Superseded by 1082753
Request History
pgajdos created request
- drop python 2 support
- added patches
fix https://github.com/beetbox/mediafile/issues/68
+ python-mediafile-pyupgrade.patch
dgarcia declined request
Reviewing the patch, looks like it's not complete, there are some leftover "import six", in mediafile.py:55 or in test/test_mediafile_edge.py:26 and test/test_mediafile.py:24
It's working because the python-six module is installed as a dependency of python-flit.
Another thing that we can improve in this package is to depend on python-flit-core instead of python-flit and remove python-setuptools dependency.
And they are using pytest for testing upstream, so maybe it's worth to chagne from pyunittest now.
superseded by 1082753