Overview
Request 1079454 accepted
- update to 2.4.0:
* Add support for alternate SMC path used with newer MacBooks, #236
* Improved systemd integration, #250, #252, 253
* Removed developer tests which confused users
- Added 0001-fix-pidfile-path.patch to align PID path to systemd service file
@amanzini Thanks a lot for the SR! One question. I've noticed that the PIDFile location in the service file was changed to /run/mbpfan.pid. The PROGRAM_PID in global.h is still /var/run/mbpfan.pid. Do we have the symlink /var/run->/run in all of the (open)SUSE flavors? Because otherwise that could be a problem I guess.
good catch! I checked SLE 15sp3 / 15sp4 + openSUSE and the symlink is present, but it could lead to issues on other flavors. So I sent an upstream pull request to update also global.h : https://github.com/linux-on-mac/mbpfan/pull/260 ; we can provide a patch in the meantime :)
Request History
amanzini created request
- update to 2.4.0:
* Add support for alternate SMC path used with newer MacBooks, #236
* Improved systemd integration, #250, #252, 253
* Removed developer tests which confused users
- Added 0001-fix-pidfile-path.patch to align PID path to systemd service file
brejoc accepted request
LGTM! Thanks again!
Thanks a lot! And also thanks for providing the patch!