This request supersedes:
request 1078457
(Show diff)
Overview
Request 1078729 accepted
- Drop n_no-compress-on-sle.patch and set XPM_PATH_COMPRESS instead
- Created by favogt
- In state accepted
- 4 package maintainers
- Supersedes 1078457
Loading...
author
source maintainer
Note that I made https://build.opensuse.org/request/show/1078456 separately to get the trivial part accepted and forwarded quicker to fix the build failure.
Login required, please
login
in order to comment
So did you try what happens when /usr/bin/compress is tried to be executed, but not availabe? What happens?
I didn't try it, but the
xpmPipeThroughfunction returns NULL, so the behaviour is identical to the patch.Hmm. Doesn't this bail out with _exit(1) in
xpmPipeThrough?Yes, but in the forked child process
Fair enough. But then we can also require ncompress - at least on openSUSE. Will add this.
Please no - that's just bloat. Making it conditional is also broken by design because "Requires" implies that it does not work without it but in SLE it does.
I'd just declare that support for writing (!!!) .Z pixmaps is "opt-in", like it's been the decades before. Using X pixmaps is rare, using .Z pixmaps is even rarer and then writing those is pretty much never going to be used.
Well, it was "opt-in" since decades, because we weren't aware of that this program uses 'compress' at all. :-( What about using Recommends or Suggests instead?
Suggests sounds good to me.