Overview

Request 1064116 superseded

- Updated to version 2.2.0:
+ Switch to meson buildsystem.
- Add meson BuildRequires and switch python to meson, meson_build
and meson_install following upstream switch to Meson build
system.
- Add hicolor-icon-theme, pkgconfig(glib-2.0),
pkgconfig(gobject-introspection-1.0), pkgconfig(gtk+-3.0) and
pkgconfig(webkit2gtk-4.0) BuildRequires, needed now that we are
using meson.
- Add python3-Levenshtein, python3-gobject, python3-pycairo,
python3-pyenchant and python3-regex to Requires, needed now that
we are using meson.
- Remove fdupes, gcc-c++ and translation-update-upstream from
BuildRequires, not needed now that we are using meson.
- Updated desktop menu categories to reflect current openSUSE
recommended categories.
- Add uberwriter-meson-data-fixes.patch: i18n desktop and appdata
meson build fixes, (gh#uberwriter/uberwriter#1).
- Drop uberwriter-fix-install.patch as this is obsolete.

Loading...

Bjørn Lie's avatar

Please see subs from luciano and me :-)



Luciano Santos's avatar
reviewer target maintainer

Thanks Malcolm for the extra pair of hands. My concerns here are:

  1. Requirements being changed (adding/removing) without documenting them in the changes file. CMake and Meson at once?
  2. Are we sure uberwriter-meson-data-fixes.patch is a downstream patch?
  3. And are we sure those Python shebang are really needed? I can't remember ever crossing a Python app that need them for anything other than the main script -- of course I haven't payed a very close attention to this details for ever Python app I came across.
  4. If we're going to fix file permissions, a better way is to rely on RPM's %attr macro:
    %attr(0755,-,-) %{_bindir}/%{name}
Request History
Malcolm Lewis's avatar

malcolmlewis created request

- Updated to version 2.2.0:
+ Switch to meson buildsystem.
- Add meson BuildRequires and switch python to meson, meson_build
and meson_install following upstream switch to Meson build
system.
- Add hicolor-icon-theme, pkgconfig(glib-2.0),
pkgconfig(gobject-introspection-1.0), pkgconfig(gtk+-3.0) and
pkgconfig(webkit2gtk-4.0) BuildRequires, needed now that we are
using meson.
- Add python3-Levenshtein, python3-gobject, python3-pycairo,
python3-pyenchant and python3-regex to Requires, needed now that
we are using meson.
- Remove fdupes, gcc-c++ and translation-update-upstream from
BuildRequires, not needed now that we are using meson.
- Updated desktop menu categories to reflect current openSUSE
recommended categories.
- Add uberwriter-meson-data-fixes.patch: i18n desktop and appdata
meson build fixes, (gh#uberwriter/uberwriter#1).
- Drop uberwriter-fix-install.patch as this is obsolete.


GNOME Review Bot's avatar

gnome-review-bot accepted review

Check script succeeded


openSUSE Build Service is sponsored by