Overview
Request 1061072 accepted
- Update to version 2.0.0:
* Switch to UTF8 based API and remove deprecated UTF16 one
(Result::text())
* Remove all API deprecated in 1.4
* Adding a wrapper for iOS
* New Aztec detector implementation to support arbitrary rotation
and position of the symbol
* Support multi-symbol detection in Aztec detector
* Replace all Qt originated ECI/CharacterSet conversion code with
a new implementation
* Require c++17 to build library and client code
* New DecodeHints::textMode() and Result::text(TextMode) API to
specify how bytes are rendered into text
* HRI (human readable interpretation) is the new default for the
TextMode (has been for most cases before, but not all)
* New DecodeHits::tryInvert() feature to test for inverted
symbols (white on black background)
- Changes from version 1.4.0:
* Note: this is an intermediary release on the way to 2.0. This
code is (supposed to be) API compatible (via the ReadBarcode.h
interface) with v1.3.0 but contains quite a few additional
deprecations. It still has SO number 1, which is as wrong as it
was for release v1.3.0 and it is not ABI compatible with 1.3
either. 2.0 will be basically 1.4 but with all deprecated API
removed and the final fix for #333.
* Reader support for Micro QRCode by @corbers
* Prepared switch from std::wstring based utf16 to std::string
based utf8 results, use new ZX_USE_UTF8 macro to transition to
the upcoming 2.0 API
* Much improved 'binary' data support via new Result::bytes()
API, see #334 for a detailed background discussion.
* New Result::contentType() API returning information about the
type of content (like text vs. binary, etc.)
* Better standards conformance with respect to ECI handling, see
Results::bytesECI()
* Support for proper ECI handling across structured append
symbols (see MergeStructuredAppendResults())
* New Result::error() API with improved error handling, see also
DecodeHints::returnErrors()
* Removed all internal header files from the installed set, so
only the ReadBarcode.h based APIs are supported from here on
out
* Removed all sample images from the 'source' distribution
zip/tar balls (much reduced size)
* Python read_barcode returns None if no symbol was found (might
break existing code if not checked for None before)
- Changes from version 1.3.0:
* Multi-barcode reading with the new std::vector
ReadBardcodes(...) function. Does not work for Aztec,
DataMatrix and Maxicode, yet.
* Multi-resolution scanning that can automatically downscale the
input to substantially increase the detection rate on high
resolution scans, see DecodeHints::tryDownscale, currently only
enabled in the ReadBardcodes function
* New Result::symbologyIdentifier property
* Updated and improved android wrapper
- Drop patches fixed upstream:
* 269.patch
* 0001-test-update-to-libfmt-v9.0.0.patch
* cmake-check-system-first.patch
- Bump sover to 3 following upstream changes. (forwarded request 1061067 from iznogood)
Open review for devel:libraries:c_c++ / zxing-cpp
Maintainers please approve / decline
Can you please wait a bit before accepting this request? I might need version 1.1.1 in SLE.
You can just submit an older revision from oS:F to SLE as well
prison (a KDE Framework) will need 1.2.0 in the next update. Please take a quick decision
%if 0%{?sle_version} looks wrong, that should compare the value
I think it is used as is_not_Tumbleweed check:
https://en.opensuse.org/openSUSE:Packaging_for_Leap#RPM_Distro_Version_Macros
Yes, but that makes no sense here
20+# Use cmake3 package on SLE12 because cmake is too old (version 3.5)
21+%if !0%{?is_opensuse} && 0%{?sle_version} < 150000
yaiks :)
%if 0%{?sle_version} && 0%{?sle_version} < 150000 ?
cycle? again? gstreamer-plugins-bad appears way too often this week.
Request History
jengelh created request
- Update to version 2.0.0:
* Switch to UTF8 based API and remove deprecated UTF16 one
(Result::text())
* Remove all API deprecated in 1.4
* Adding a wrapper for iOS
* New Aztec detector implementation to support arbitrary rotation
and position of the symbol
* Support multi-symbol detection in Aztec detector
* Replace all Qt originated ECI/CharacterSet conversion code with
a new implementation
* Require c++17 to build library and client code
* New DecodeHints::textMode() and Result::text(TextMode) API to
specify how bytes are rendered into text
* HRI (human readable interpretation) is the new default for the
TextMode (has been for most cases before, but not all)
* New DecodeHits::tryInvert() feature to test for inverted
symbols (white on black background)
- Changes from version 1.4.0:
* Note: this is an intermediary release on the way to 2.0. This
code is (supposed to be) API compatible (via the ReadBarcode.h
interface) with v1.3.0 but contains quite a few additional
deprecations. It still has SO number 1, which is as wrong as it
was for release v1.3.0 and it is not ABI compatible with 1.3
either. 2.0 will be basically 1.4 but with all deprecated API
removed and the final fix for #333.
* Reader support for Micro QRCode by @corbers
* Prepared switch from std::wstring based utf16 to std::string
based utf8 results, use new ZX_USE_UTF8 macro to transition to
the upcoming 2.0 API
* Much improved 'binary' data support via new Result::bytes()
API, see #334 for a detailed background discussion.
* New Result::contentType() API returning information about the
type of content (like text vs. binary, etc.)
* Better standards conformance with respect to ECI handling, see
Results::bytesECI()
* Support for proper ECI handling across structured append
symbols (see MergeStructuredAppendResults())
* New Result::error() API with improved error handling, see also
DecodeHints::returnErrors()
* Removed all internal header files from the installed set, so
only the ReadBarcode.h based APIs are supported from here on
out
* Removed all sample images from the 'source' distribution
zip/tar balls (much reduced size)
* Python read_barcode returns None if no symbol was found (might
break existing code if not checked for None before)
- Changes from version 1.3.0:
* Multi-barcode reading with the new std::vector
ReadBardcodes(...) function. Does not work for Aztec,
DataMatrix and Maxicode, yet.
* Multi-resolution scanning that can automatically downscale the
input to substantially increase the detection rate on high
resolution scans, see DecodeHints::tryDownscale, currently only
enabled in the ReadBardcodes function
* New Result::symbologyIdentifier property
* Updated and improved android wrapper
- Drop patches fixed upstream:
* 269.patch
* 0001-test-update-to-libfmt-v9.0.0.patch
* cmake-check-system-first.patch
- Bump sover to 3 following upstream changes. (forwarded request 1061067 from iznogood)
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar_suse set openSUSE:Factory:Staging:D as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:D"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:D"
dimstar_suse added factory-staging as a reviewer
Being evaluated by group "factory-staging"
dimstar_suse accepted review
Unstaged from project "openSUSE:Factory:Staging:D"
dimstar_suse set openSUSE:Factory:Staging:L as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:L"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:L"
dimstar accepted review
dimstar_suse added factory-staging as a reviewer
Being evaluated by group "factory-staging"
dimstar_suse accepted review
Unstaged from project "openSUSE:Factory:Staging:L"
dimstar_suse set openSUSE:Factory:Staging:E as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:E"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:E"
dimstar_suse added factory-staging as a reviewer
Being evaluated by group "factory-staging"
dimstar_suse accepted review
Unstaged from project "openSUSE:Factory:Staging:E"
dimstar_suse set openSUSE:Factory:Staging:L as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:L"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:L"
dimstar_suse added factory-staging as a reviewer
Being evaluated by group "factory-staging"
dimstar_suse accepted review
Unstaged from project "openSUSE:Factory:Staging:L"
dimstar_suse set openSUSE:Factory:Staging:E as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:E"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:E"
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:E got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:E got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:E got accepted.
breaks gstreamer-plugins-bad:
[ 155s] In file included from /usr/include/ZXing/DecodeHints.h:10, [ 155s] from /usr/include/ZXing/ReadBarcode.h:8, [ 155s] from ../ext/zxing/gstzxing.cpp:63: [ 155s] /usr/include/ZXing/BarcodeFormat.h:59:44: error: ‘string_view’ is not a member of ‘std’ [ 155s] 59 | BarcodeFormat BarcodeFormatFromString(std::string_view str); [ 155s] | ^~~~~~~~~~~ [ 155s] /usr/include/ZXing/BarcodeFormat.h:59:44: note: ‘std::string_view’ is only available from C++17 onwards [ 155s] /usr/include/ZXing/BarcodeFormat.h:68:46: error: ‘string_view’ is not a member of ‘std’ [ 155s] 68 | BarcodeFormats BarcodeFormatsFromString(std::string_view str); [ 155s] | ^~~~~~~~~~~ [ 155s] /usr/include/ZXing/BarcodeFormat.h:68:46: note: ‘std::string_view’ is only available from C++17 onwards [ 155s] In file included from /usr/include/ZXing/DecodeHints.h:11: [ 155s] /usr/include/ZXing/CharacterSet.h:56:42: error: ‘string_view’ is not a member of ‘std’ [ 155s] 56 | CharacterSet CharacterSetFromString(std::string_view name); [ 155s] | ^~~~~~~~~~~ [ 155s] /usr/include/ZXing/CharacterSet.h:56:42: note: ‘std::string_view’ is only available from C++17 onwards [ 155s] /usr/include/ZXing/DecodeHints.h:155:43: error: ‘std::string_view’ has not been declared [ 155s] 155 | DecodeHints& setCharacterSet(std::string_view v)& { return _characterSet = CharacterSetFromString(v), *this; } [ 155s] | ^~~~~~~~~~~ [ 155s] /usr/include/ZXing/DecodeHints.h:156:44: error: ‘std::string_view’ has not been declared [ 155s] 156 | DecodeHints&& setCharacterSet(std::string_view v) && { return _characterSet = CharacterSetFromString(v), std::move(*this); } [ 155s] | ^~~~~~~~~~~ [ 155s] /usr/include/ZXing/DecodeHints.h: In member function ‘ZXing::DecodeHints& ZXing::DecodeHints::setCharacterSet(int) &’: [ 155s] /usr/include/ZXing/DecodeHints.h:155:106: error: ‘ZXing::CharacterSetFromString’ cannot be used as a function [ 155s] 155 | DecodeHints& setCharacterSet(std::string_view v)& { return _characterSet = CharacterSetFromString(v), *this; } [ 155s] | ~~~~~~~~~~~~~~~~~~~~~~^~~ [ 155s] /usr/include/ZXing/DecodeHints.h: In member function ‘ZXing::DecodeHints&& ZXing::DecodeHints::setCharacterSet(int) &&’: [ 155s] /usr/include/ZXing/DecodeHints.h:156:109: error: ‘ZXing::CharacterSetFromString’ cannot be used as a function [ 155s] 156 | DecodeHints&& setCharacterSet(std::string_view v) && { return _characterSet = CharacterSetFromString(v), std::move(*this); } [ 155s] | ~~~~~~~~~~~~~~~~~~~~~~^~~ [ 155s] In file included from /usr/include/ZXing/Result.h:11, [ 155s] from /usr/include/ZXing/ReadBarcode.h:10: [ 155s] /usr/include/ZXing/ByteArray.h: At global scope: [ 155s] /usr/include/ZXing/ByteArray.h:30:14: error: ‘string_view’ in namespace ‘std’ does not name a type [ 155s] 30 | std::string_view asString(size_t pos = 0, size_t len = std::string_view::npos) const [ 155s] | ^~~~~~~~~~~ [ 155s] /usr/include/ZXing/ByteArray.h:30:9: note: ‘std::string_view’ is only available from C++17 onwards [ 155s] 30 | std::string_view asString(size_t pos = 0, size_t len = std::string_view::npos) const [ 155s] | ^~~ [ 155s] In file included from /usr/include/ZXing/Result.h:14: [ 155s] /usr/include/ZXing/Error.h: In function ‘std::string ZXing::ToString(const Error&)’: [ 155s] /usr/include/ZXing/Error.h:65:13: warning: init-statement in selection statements only available with ‘-std=c++17’ or ‘-std=gnu++17’ [-Wc++17-extensions] [ 155s] 65 | if (auto location = e.location(); !location.empty()) [ 155s] | ^~~~https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:L/gstreamer-plugins-bad/standard/x86_64
Needed for the new gstreamer bad stable branch (1.22.x)
Seems responsible for LO failure
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:E/libreoffice/standard/x86_64
CC @mcalabkova, @dspinella
LibreOffice seems not to like this zxing-cpp update and fails to build (BitArray.h no longer found)
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:E/libreoffice/standard/x86_64
Fixed upstream:
https://cgit.freedesktop.org/libreoffice/core/commit/cui/source/dialogs/QrCodeGenDialog.cxx?id=15e5d86cc55ad94ac946e04d5e25b84be5810970
https://github.com/zxing-cpp/zxing-cpp/issues/361
https://build.opensuse.org/request/show/1061604
https://build.opensuse.org/request/show/1062045
Was asked to sub to a different target