Overview

Request 1010566 superseded

No description set
Loading...

Dominique Leuenberger's avatar

@Andreas_Schwab just in case you're not aware: this SR has a blocking review on you


Fabian Vogt's avatar

%requires_eq is only for %{version}. If you want actual rebuilds you need Requires: kernel-source = %(rpm -q --qf %%{version}-%%{release} kernel-source)


Tony Jones's avatar

I thought there was already a mechanism in place that was rebuilding perf on each kernel source change. This is what I recall the build team telling me. Admittedly I don't know the details.


Fabian Vogt's avatar

There is indeed: perf is mentioned in rebuildpacs-leafs, so it is rebuilt for every Tumbleweed snapshot. With this approach that's changed to only rebuild if the kernel changes.


Andreas Schwab's avatar

This is for Factory, where every kernel update also changes the version, so it is working well without the workaround.


Fabian Vogt's avatar

So contrary to the comment it's not about kernel rebuilds at all but only source changes?


Andreas Schwab's avatar

Which comment talks about "kernel rebuilds"?


Fabian Vogt's avatar
+This is an empty package that ensures perf is rebuilt every time
+kernel-default is rebuilt in OBS.

Andreas Schwab's avatar

That's the same as in all other -rebuild packages.


Fabian Vogt's avatar

Which hopefully use %{release} as well?


Andreas Schwab's avatar

It's just a workaround for packages that don't do it right

Request History
Jiri Slaby's avatar

jirislaby created request


Jiri Slaby's avatar

jirislaby added favogt as a reviewer

.


Jiri Slaby's avatar

jirislaby added Andreas_Schwab as a reviewer

.


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Staging Bot's avatar

staging-bot added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:78"


Staging Bot's avatar

staging-bot accepted review

Picked "openSUSE:Factory:Staging:adi:78"


Fabian Vogt's avatar

favogt accepted review

FWICT the description of the -rebuild subpackage is still wrong, but that's not a blocker.


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar declined review

As the blocking review seems not to be cleaned up: please resubmit (so it can progress)


Dominique Leuenberger's avatar

dimstar declined request

As the blocking review seems not to be cleaned up: please resubmit (so it can progress)


Dominique Leuenberger's avatar

dimstar_suse reopened request

Reopened via staging workflow.


Dominique Leuenberger's avatar

dimstar_suse added factory-staging as a reviewer

Being evaluated by group "factory-staging"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Unstaged from project "openSUSE:Factory:Staging:adi:78"


Dominique Leuenberger's avatar

dimstar_suse declined request

Declined via staging workflow.


Jiri Slaby's avatar

jirislaby superseded request

superseded by 1057729

openSUSE Build Service is sponsored by