Overview
Request 1004956 accepted
* Add mathgl-libharu2_4-compat.patch: Fix compilation against libharu 2.4.x [https://sourceforge.net/p/mathgl/bugs/48/].
* Build against wxWidgets >= 3.1 (wxGTK3) instead of wxWidgets=3.0.
- Created by badshah400
- In state accepted
-
Package maintainer:
badshah400
- Supersedes 1004531
Leap only has haru 2.3.0.
#include "hpdf_version.h" ... #if HPDF_VERSION_MAJOR >= 2 && HPDF_VERSION_MINOR >= 4 ...
You may also want to exchange wxWidgets (GTK3) with wxGTK3.
Probably, also split mgllab and udav. Both seem to do more or less the same, but one uses FLTK, the other one Qt, and pull in the corresponding libraries.
Thanks for the review and for the suggestions improving the patch. I ended up using #if HPDF_VERSION_ID >= 20400 which seemed simpler but uses the same idea.
Have not yet got to splitting mgllab and udav, since they use the same icon in their .desktop files. Will need to duplicate this icon, install it as 'mgllab.png', and patch the desktop file to use that, as I understand, but probably best to do the entire thing with patches to the cmake files so it can be submitted to upstream as well.
The switch to wxGTK3 and improved patch are in sr#1004956.
Request History
badshah400 created request
* Add mathgl-libharu2_4-compat.patch: Fix compilation against libharu 2.4.x [https://sourceforge.net/p/mathgl/bugs/48/].
* Build against wxWidgets >= 3.1 (wxGTK3) instead of wxWidgets=3.0.
badshah400 accepted request
Thanks for the review, will look into splitting udav and mgllab, and the segfaulting issue you've highlighted as my next point-to-do.
Hm, on i586 it segfaults: "[texinfo/CMakeFiles/doc_html.dir/build.make:841: texinfo/png/colorbar.png] Segmentation fault"
This may be caused by a racy Makefile, the command "cd /home/abuild/rpmbuild/BUILD/python3.10_build/texinfo/png && /home/abuild/rpmbuild/BUILD/python3.10_build/examples/mgl_example -kind=colorbar" is issued twice.
This recurrently happens when people use CMake incorrectly.
Honestly, nothing I would worry much about.
TLDR: LGTM