Overview
Request 1001022 accepted
fixed upgrade in spec file
- Created by bobbie424242
- In state accepted
- Supersedes 1001013
+%post
71+%service_add_post %{name}.service
72+if [ -d %{_datadir}/libinput* ]; then
73+ mkdir -p %{_sysconfdir}/libinput
74+ echo "# added by %{name} package: START" >> %{libinput_overrides}
75+ cat %{_datadir}/%{name}/keyd.quirks >> %{libinput_overrides}
76+ echo "# added by %{name} package: END" >> %{libinput_overrides}
77+fi
That sounds quite fragile on updates:
- Mkdir will fail if it already exists
- The file libinput_overrides will grow with every update
Thank you for the review.
-
mkdir -pdoes not fail if the directory exist. - good catch about the file growing, will fix.
Request History
bobbie424242 created request
fixed upgrade in spec file
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
staging-bot added openSUSE:Factory:Staging:adi:9 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:9"
staging-bot accepted review
Picked "openSUSE:Factory:Staging:adi:9"
dimstar accepted review
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:adi:9 got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:adi:9 got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:adi:9 got accepted.
