File 0001-PostFileData-randomString-properly-cast-fr... of Package attica-qt5

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-PostFileData-randomString-properly-cast-from-char-to.patch of Package attica-qt5

From cd8b66167f343f214ddc221028c5343576a029df Mon Sep 17 00:00:00 2001
From: "Friedrich W. H. Kossebau" <kossebau@kde.org>
Date: Thu, 12 Nov 2020 01:15:12 +0100
Subject: [PATCH 1/1] PostFileData::randomString: properly cast from char to
 QChar

QT_NO_CAST_FROM_ASCII can break code without the compiler warning about
when one assigns chars > 127 to a QCharRef. Because instead of the
no longer available char argument overload the int overload is used:
QCharRef &QCharRefoperator=(int rc)
which then gets bad negative values passed after the implicit cast.

Never happens here but better safe then sorry, also preparing for the
case future Qt properly catches a left-over assignment from a char type
to a QCharRef.

NO_CHANGELOG
---
 src/postfiledata.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/postfiledata.cpp b/src/postfiledata.cpp
index 2686a4d..d25098c 100644
--- a/src/postfiledata.cpp
+++ b/src/postfiledata.cpp
@@ -61,7 +61,7 @@ QString PostFileData::randomString(int length)
         if (r > 90) {
             r += 6;
         }
-        str[i++] =  char(r);
+        str[i++] = QLatin1Char(char(r));
     }
     return str;
 }
-- 
2.32.0

Places

File 0001-PostFileData-randomString-properly-cast-from-char-to.patch of Package attica-qt5

Places