File 5dd6b229-add-va_end-to-hypercall_create_continu... of Package xen.13549

Overview Repositories Revisions Requests Users Attributes Meta

File 5dd6b229-add-va_end-to-hypercall_create_continuation.patch of Package xen.13549

# Commit df7a19338a892b5cf585fd2bee8584cb15e0cace
# Date 2019-11-21 15:50:01 +0000
# Author Julien Grall <julien@xen.org>
# Committer Andrew Cooper <andrew.cooper3@citrix.com>
xen: Add missing va_end() in hypercall_create_continuation()

The documentation requires va_start() to always be matched with a
corresponding va_end(). However, this is not the case in the path used
for bad format.

This was introduced by XSA-296.

Coverity-ID: 1488727
Fixes: 0bf9f8d3e3 ("xen/hypercall: Don't use BUG() for parameter checking in hypercall_create_continuation()")
Signed-off-by: Julien Grall <julien@xen.org>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Andrew Cooper <andrew.cooper3@citrix.com>

--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -477,6 +477,7 @@ unsigned long hypercall_create_continuat
     return rc;
 
  bad_fmt:
+    va_end(args);
     gprintk(XENLOG_ERR, "Bad hypercall continuation format '%c'\n", *p);
     ASSERT_UNREACHABLE();
     domain_crash(current->domain);
--- a/xen/arch/x86/hypercall.c
+++ b/xen/arch/x86/hypercall.c
@@ -156,6 +156,7 @@ unsigned long hypercall_create_continuat
     return op;
 
  bad_fmt:
+    va_end(args);
     gprintk(XENLOG_ERR, "Bad hypercall continuation format '%c'\n", *p);
     ASSERT_UNREACHABLE();
     domain_crash(curr->domain);

Places

File 5dd6b229-add-va_end-to-hypercall_create_continuation.patch of Package xen.13549

Places