File Do-not-use-function-returning-reference-to-temp... of Package kdevelop4

Overview Repositories Revisions Requests Users Attributes Meta

File Do-not-use-function-returning-reference-to-temporary.patch of Package kdevelop4

From: Sébastien Lambert <opensc@beonis.fr>
Date: Mon, 22 Jun 2015 20:48:35 +0000
Subject: Do not use function returning reference to temporary.
X-Git-Url: http://quickgit.kde.org/?p=kdevelop.git&a=commitdiff&h=6ef7b373a2284e24753b6eb249ba68da5d9a2444
---
Do not use function returning reference to temporary.

REVIEW: 124126
BUG: 347178
---

--- a/languages/cpp/cppduchain/cpppreprocessenvironment.cpp
+++ b/languages/cpp/cppduchain/cpppreprocessenvironment.cpp
@@ -117,7 +117,7 @@
       rpp::Environment::setMacro(const_cast<rpp::pp_macro*>(&it.ref())); //Do not use our overridden setMacro(..), because addDefinedMacro(..) is not needed(macro-sets should be merged separately)
 
     for( Cpp::ReferenceCountedStringSet::Iterator it = file->definedMacroNames().iterator(); it; ++it ) {
-      m_macroNameSet.insert(it.ref());
+      m_macroNameSet.insert(*it);
     }
 
     //We don't have to care about efficiency too much here, unDefinedMacros should be a rather small set
@@ -126,7 +126,7 @@
         m->defined = false;
         m->m_valueHashValid = false;
         rpp::Environment::setMacro(m); //Do not use our overridden setMacro(..), because addDefinedMacro(..) is not needed(macro-sets should be merged separately)
-        m_macroNameSet.remove(it.ref());
+        m_macroNameSet.remove(*it);
     }
 }

Places

File Do-not-use-function-returning-reference-to-temporary.patch of Package kdevelop4

Places