File 0139-s390x-pci-Ignore-the-unplug-call-if.patch of Package qemu-testsuite.18974

Overview Repositories Revisions Requests Users Attributes Meta

File 0139-s390x-pci-Ignore-the-unplug-call-if.patch of Package qemu-testsuite.18974

From: David Hildenbrand <david@redhat.com>
Date: Mon, 14 Jan 2019 11:31:08 +0100
Subject: s390x/pci: Ignore the unplug call if we already have a release_timer

Include-If: %if 0%{?suse_version} == 1315
Git-commit: 3549f8c9e4f0ef1c3417ff43b2164f68ad34b922
References: bsc#1179725

... otherwise two successive calls to qdev_unplug() (e.g. by an impatient
user) will effectively overwrite pbdev->release_timer, resulting in a
memory leak. We are already processing the unplug.

If there is already a release_timer, the unplug will be performed after
the timeout.

Can be easily triggered by
(hmp) device_add virtio-mouse-pci,id=test
(hmp) stop
(hmp) device_del test
(hmp) device_del test

Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190114103110.10909-5-david@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Cho, Yu-Chen <acho@suse.com>
---
 hw/s390x/s390-pci-bus.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index 71a7769d9c4722dc4820db4c3aba..e077d5d3abcdac272dfe2b4f0d35 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
@@ -980,6 +980,9 @@ static void s390_pcihost_unplug(HotplugHandler *hotplug_dev, DeviceState *dev,
     case ZPCI_FS_STANDBY:
         break;
     default:
+        if (pbdev->release_timer) {
+            return;
+        }
         s390_pci_generate_plug_event(HP_EVENT_DECONFIGURE_REQUEST,
                                      pbdev->fh, pbdev->fid);
         pbdev->release_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL,

Places

File 0139-s390x-pci-Ignore-the-unplug-call-if.patch of Package qemu-testsuite.18974

Places