File 0121-tests-fix-TLS-handshake-failure-wit.patch of Package qemu-testsuite.12241

Overview Repositories Revisions Requests Users Attributes Meta

File 0121-tests-fix-TLS-handshake-failure-wit.patch of Package qemu-testsuite.12241

From 9fab16763bd76fa480d378be604076f5095e648f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>
Date: Wed, 18 Jul 2018 10:24:59 +0100
Subject: [PATCH] tests: fix TLS handshake failure with TLS 1.3
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When gnutls negotiates TLS 1.3 instead of 1.2, the order of messages
sent by the handshake changes. This exposed a logic bug in the test
suite which caused us to wait for the server to see handshake
completion, but not wait for the client to see completion. The result
was the client didn't receive the certificate for verification and the
test failed.

This is exposed in Fedora 29 rawhide which has just enabled TLS 1.3 in
its GNUTLS builds.

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
(cherry picked from commit db0a8c70f25fe497c4b786d8edac063daa744c0d)
Signed-off-by: Bruce Rogers <brogers@suse.com>
---
 tests/test-crypto-tlssession.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/test-crypto-tlssession.c b/tests/test-crypto-tlssession.c
index 82f21c27f2..4416a85241 100644
--- a/tests/test-crypto-tlssession.c
+++ b/tests/test-crypto-tlssession.c
@@ -227,7 +227,7 @@ static void test_crypto_tls_session(const void *opaque)
                 clientShake = true;
             }
         }
-    } while (!clientShake && !serverShake);
+    } while (!clientShake || !serverShake);
 
 
     /* Finally make sure the server validation does what

Places

File 0121-tests-fix-TLS-handshake-failure-wit.patch of Package qemu-testsuite.12241

Places