File 1006-Grow-fix-can-t-change-bitmap-type-from-non... of Package mdadm

Overview Repositories Revisions Requests Users Attributes Meta

File 1006-Grow-fix-can-t-change-bitmap-type-from-none-to-clust.patch of Package mdadm

This patch for bsc#1208618.
Current status: patch had been filed to upstream for review.
URL:
https://lore.kernel.org/linux-raid/20230223143939.3817-1-heming.zhao@suse.com/T/#u

---
From 677816c0baf0799c23a81747e21ab341907162ab Mon Sep 17 00:00:00 2001
From: Heming Zhao <heming.zhao@suse.com>
Date: Thu, 23 Feb 2023 22:23:27 +0800
Subject: [PATCH] Grow: fix can't change bitmap type from none to clustered.
To: linux-raid@vger.kernel.org,
    jes@trained-monkey.org,
    ncroxon@redhat.com
Cc: colyli@suse.de

Commit a042210648ed ("disallow create or grow clustered bitmap with
writemostly set") introduced this bug. We should use 'true' logic not
'== 0' to deny setting up clustered array under WRITEMOSTLY condition.

How to trigger

```
~/mdadm # ./mdadm -Ss && ./mdadm --zero-superblock /dev/sd{a,b}
~/mdadm # ./mdadm -C /dev/md0 -l mirror -b clustered -e 1.2 -n 2 \
/dev/sda /dev/sdb --assume-clean
mdadm: array /dev/md0 started.
~/mdadm # ./mdadm --grow /dev/md0 --bitmap=none
~/mdadm # ./mdadm --grow /dev/md0 --bitmap=clustered
mdadm: /dev/md0 disks marked write-mostly are not supported with clustered bitmap
```

Signed-off-by: Heming Zhao <heming.zhao@suse.com>
---
 Grow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Grow.c b/Grow.c
index 8f5cf07d10d9..bb5fe45c851c 100644
--- a/Grow.c
+++ b/Grow.c
@@ -429,7 +429,7 @@ int Grow_addbitmap(char *devname, int fd, struct context *c, struct shape *s)
 			dv = map_dev(disk.major, disk.minor, 1);
 			if (!dv)
 				continue;
-			if (((disk.state & (1 << MD_DISK_WRITEMOSTLY)) == 0) &&
+			if ((disk.state & (1 << MD_DISK_WRITEMOSTLY)) &&
 			   (strcmp(s->bitmap_file, "clustered") == 0)) {
 				pr_err("%s disks marked write-mostly are not supported with clustered bitmap\n",devname);
 				return 1;
-- 
2.39.1

Places

File 1006-Grow-fix-can-t-change-bitmap-type-from-none-to-clust.patch of Package mdadm

Places