File irqbalance-ui-skip-in-parse_setup-to-avoid-core... of Package irqbalance.27232

Overview Repositories Revisions Requests Users Attributes Meta

File irqbalance-ui-skip-in-parse_setup-to-avoid-coredump.patch of Package irqbalance.27232

From: Liu Chao <liuchao173@huawei.com>
Subject: irqbalance-ui: skip ',' in parse_setup to avoid coredump
References: bsc#1204961
Patch-Mainline: v1.9.1
Git-commit: c8d1fff0f16ad906cca153a22faac11516ccc0dd
Git-repo: https://github.com/Irqbalance/irqbalance.git.git

When processing the ',' in hex_to_bitmap, it returns '0000\ 0' directly.
The return value will be freed in parse_setup, but it is not requested
through malloc.

Fixes: 85d37098a551 ("Fix several memleak problems found by covscan")

And it treat ',' as "0000", which cause irqbalance-ui will display wrong
Banned CPU numbers.

For example:
# IRQBALANCE_BANNED_CPUS="00000002,00000000,00000000" ./irqbalance
or
# IRQBALANCE_BANNED_CPULIST="65" ./irqbalance

# ./irqbalance-ui
Banned CPU numbers: 73

Fixes: 76d1c9d73935 ("Add main user interface files")

Signed-off-by: Liu Chao <liuchao173@huawei.com>

Signed-off-by:  <trenn@suse.com>
Index: irqbalance-1.8.0.18.git+2435e8d/ui/irqbalance-ui.c
===================================================================
--- irqbalance-1.8.0.18.git+2435e8d.orig/ui/irqbalance-ui.c
+++ irqbalance-1.8.0.18.git+2435e8d/ui/irqbalance-ui.c
@@ -132,7 +132,7 @@ char * get_data(char *string)
 void parse_setup(char *setup_data)
 {
 	char *token, *ptr;
-	int i,j;
+	int i,j, cpu = 0;
 	char *copy;
 	irq_t *new_irq = NULL;
 	if((setup_data == NULL) || (strlen(setup_data) == 0)) return;
@@ -169,14 +169,17 @@ void parse_setup(char *setup_data)
 	if(strncmp(token, "BANNED", strlen("BANNED"))) goto out;
 	token = strtok_r(NULL, " ", &ptr);
 	for(i = strlen(token) - 1; i >= 0; i--) {
+		if (token[i] == ',')
+			continue;
 		char *map = hex_to_bitmap(token[i]);
 		for(j = 3; j >= 0; j--) {
 			if(map[j] == '1') {
 				uint64_t *banned_cpu = malloc(sizeof(uint64_t));
-				*banned_cpu = (4 * (strlen(token) - (i + 1)) + (4 - (j + 1)));
+				*banned_cpu = cpu;
 				setup.banned_cpus = g_list_append(setup.banned_cpus,
 								banned_cpu);
 			}
+			cpu++;
 		}
 		free(map);

Places

File irqbalance-ui-skip-in-parse_setup-to-avoid-coredump.patch of Package irqbalance.27232

Places