File mgmt-tester-Fix-null-dereference-issue-reported... of Package bluez.28316

Overview Repositories Revisions Requests Users Attributes Meta

File mgmt-tester-Fix-null-dereference-issue-reported-by-s.patch of Package bluez.28316

From e3c92f1f786f0b55440bd908b55894d0c792cf0e Mon Sep 17 00:00:00 2001
From: Tedd Ho-Jeong An <tedd.an@intel.com>
Date: Wed, 22 Jun 2022 21:45:20 -0700
Subject: [PATCH] mgmt-tester: Fix null dereference issue reported by
 scan-build

This patch fixes the null dereference reported by the scan-build.

tools/mgmt-tester.c:12025:28: warning: Access to field 'cap_len' results
in a dereference of a null pointer (loaded from variable 'rp')
[core.NullDereference]

if (sizeof(rp->cap_len) + rp->cap_len != length) {
                                  ^~~~~~~~~~~
---
 tools/mgmt-tester.c | 2 ++
 1 file changed, 2 insertions(+)

Index: bluez-5.62/tools/mgmt-tester.c
===================================================================
--- bluez-5.62.orig/tools/mgmt-tester.c
+++ bluez-5.62/tools/mgmt-tester.c
@@ -10448,12 +10448,14 @@ static void read_50_controller_cap_compl
 		tester_warn("Failed to read advertising features: %s (0x%02x)",
 						mgmt_errstr(status), status);
 		tester_test_failed();
+		return;
 	}
 
 	if (sizeof(rp->cap_len) + rp->cap_len != length) {
 		tester_warn("Controller capabilities malformed, size %zu != %u",
 				sizeof(rp->cap_len) + rp->cap_len, length);
 		tester_test_failed();
+		return;
 	}
 
 	while (offset < rp->cap_len) {

Places

File mgmt-tester-Fix-null-dereference-issue-reported-by-s.patch of Package bluez.28316

Places