File 82be0ffe-conf-validate-serial-port-model.patch of Package libvirt.33033

Overview Repositories Revisions Requests Users Attributes Meta

File 82be0ffe-conf-validate-serial-port-model.patch of Package libvirt.33033

commit 82be0ffe63a1ad32ad582db9644cb83712dda8cb
Author: Daniel P. Berrangé <berrange@redhat.com>
Date:   Wed Feb 2 11:43:09 2022 +0000

conf: validate serial port model in ABI checks
    
    The serial port model cannot be allowed to change across migration
    as it affects ABI.
    
    Reviewed-by: Andrea Bolognani <abologna@redhat.com>
    Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Index: libvirt-8.0.0/src/conf/domain_conf.c
===================================================================
--- libvirt-8.0.0.orig/src/conf/domain_conf.c
+++ libvirt-8.0.0/src/conf/domain_conf.c
@@ -21292,6 +21292,14 @@ virDomainSerialDefCheckABIStability(virD
         return false;
     }
 
+    if (src->targetModel != dst->targetModel) {
+        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+                       _("Target serial model %s does not match source %s"),
+                       virDomainChrSerialTargetModelTypeToString(dst->targetModel),
+                       virDomainChrSerialTargetModelTypeToString(src->targetModel));
+        return false;
+    }
+
     if (src->target.port != dst->target.port) {
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                        _("Target serial port %d does not match source %d"),

Places

File 82be0ffe-conf-validate-serial-port-model.patch of Package libvirt.33033

Places