File readelf-fix-off-by-one-sanity-check.patch of Package elfutils.8903

Overview Repositories Revisions Requests Users Attributes Meta

File readelf-fix-off-by-one-sanity-check.patch of Package elfutils.8903

From: Mark Wielaard <mark at klomp dot org>
Date: Fri, 24 Mar 2017 12:15:02 +0100
Subject: [PATCH] readelf: Fix off by one sanity check in handle_gnu_hash
References: bnc#1033084
Upstream: https://sourceware.org/ml/elfutils-devel/2017-q1/msg00109.html

We sanity check to make sure we don't index outside the chain array
by testing inner > max_nsyms. But inner is a zero-based index, while
max_nsyms is the maximum number. Change the check to inner >= max_nsyms.

https://sourceware.org/bugzilla/show_bug.cgi?id=21299

Elfutils packaging edits:
 - changelog hunk removed from original patch to avoid conflict

Signed-off-by: Mark Wielaard <mark@klomp.org>
---
 src/readelf.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/readelf.c b/src/readelf.c
index 8d96ba3..490b6d5 100644
--- a/src/readelf.c
+++ b/src/readelf.c
@@ -3263,7 +3263,7 @@ handle_gnu_hash (Ebl *ebl, Elf_Scn *scn, GElf_Shdr *shdr, size_t shstrndx)
 	    ++nsyms;
 	    if (maxlength < ++lengths[cnt])
 	      ++maxlength;
-	    if (inner > max_nsyms)
+	    if (inner >= max_nsyms)
 	      goto invalid_data;
 	  }
 	while ((chain[inner++] & 1) == 0);
-- 
1.8.3.1

Places

File readelf-fix-off-by-one-sanity-check.patch of Package elfutils.8903

Places