File 0001-Remove-external-Base64Coder-and-use-provid... of Package snakeyaml

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-Remove-external-Base64Coder-and-use-provided-Base64.patch of Package snakeyaml (Revision cef6397f01ba432db9e15e603763bac2)

Currently displaying revision cef6397f01ba432db9e15e603763bac2 , Show latest

From 6519dac7af0b7fed04b3dfeaada0023ea75fa881 Mon Sep 17 00:00:00 2001
From: Andrey Somov <public.somov@gmail.com>
Date: Sat, 6 Apr 2024 16:56:51 +0400
Subject: [PATCH 1/2] Remove external Base64Coder and use provided Base64

---
 pom.xml                                       |   6 +-
 .../constructor/SafeConstructor.java          |  14 +-
 .../external/biz/base64Coder/Base64Coder.java | 281 ------------------
 .../representer/SafeRepresenter.java          |  22 +-
 .../base64Coder/Base64CoderTest.java          |  17 +-
 .../issues/issue99/YamlBase64Test.java        |   8 +-
 6 files changed, 22 insertions(+), 326 deletions(-)
 delete mode 100644 src/main/java/org/yaml/snakeyaml/external/biz/base64Coder/Base64Coder.java

diff --git a/pom.xml b/pom.xml
index e4b15074..c242d07d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -10,9 +10,9 @@
         <project.scm.id>bitbucket</project.scm.id>
         <release.repo.url>https://oss.sonatype.org/service/local/staging/deploy/maven2/</release.repo.url>
         <snapshot.repo.url>https://oss.sonatype.org/content/repositories/snapshots/</snapshot.repo.url>
-        <maven.compiler.source>7</maven.compiler.source>
-        <maven.compiler.target>7</maven.compiler.target>
-        <maven.compiler.release>7</maven.compiler.release>
+        <maven.compiler.source>8</maven.compiler.source>
+        <maven.compiler.target>8</maven.compiler.target>
+        <maven.compiler.release>8</maven.compiler.release>
         <maven.javadoc.failOnError>false</maven.javadoc.failOnError>
         <maven-bundle-plugin.version>5.1.8</maven-bundle-plugin.version>
         <maven-resources-plugin.version>3.1.0</maven-resources-plugin.version>
diff --git a/src/main/java/org/yaml/snakeyaml/constructor/SafeConstructor.java b/src/main/java/org/yaml/snakeyaml/constructor/SafeConstructor.java
index e6dcd406..5ddeb13f 100644
--- a/src/main/java/org/yaml/snakeyaml/constructor/SafeConstructor.java
+++ b/src/main/java/org/yaml/snakeyaml/constructor/SafeConstructor.java
@@ -14,21 +14,11 @@
 package org.yaml.snakeyaml.constructor;
 
 import java.math.BigInteger;
-import java.util.ArrayList;
-import java.util.Calendar;
-import java.util.HashMap;
-import java.util.Iterator;
-import java.util.LinkedHashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.Set;
-import java.util.TimeZone;
-import java.util.TreeSet;
+import java.util.*;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 import org.yaml.snakeyaml.LoaderOptions;
 import org.yaml.snakeyaml.error.YAMLException;
-import org.yaml.snakeyaml.external.biz.base64Coder.Base64Coder;
 import org.yaml.snakeyaml.nodes.MappingNode;
 import org.yaml.snakeyaml.nodes.Node;
 import org.yaml.snakeyaml.nodes.NodeId;
@@ -386,7 +376,7 @@ public class SafeConstructor extends BaseConstructor {
     public Object construct(Node node) {
       // Ignore white spaces for base64 encoded scalar
       String noWhiteSpaces = constructScalar((ScalarNode) node).replaceAll("\\s", "");
-      byte[] decoded = Base64Coder.decode(noWhiteSpaces.toCharArray());
+      byte[] decoded = Base64.getDecoder().decode(noWhiteSpaces);
       return decoded;
     }
   }
diff --git a/src/main/java/org/yaml/snakeyaml/external/biz/base64Coder/Base64Coder.java b/src/main/java/org/yaml/snakeyaml/external/biz/base64Coder/Base64Coder.java
deleted file mode 100644
index db43b474..00000000
--- a/src/main/java/org/yaml/snakeyaml/external/biz/base64Coder/Base64Coder.java
+++ /dev/null
@@ -1,281 +0,0 @@
-// Copyright 2003-2010 Christian d'Heureuse, Inventec Informatik AG, Zurich, Switzerland
-// www.source-code.biz, www.inventec.ch/chdh
-//
-// This module is multi-licensed and may be used under the terms
-// of any of the following licenses:
-//
-// EPL, Eclipse Public License, V1.0 or later, http://www.eclipse.org/legal
-// LGPL, GNU Lesser General Public License, V2.1 or later, http://www.gnu.org/licenses/lgpl.html
-// GPL, GNU General Public License, V2 or later, http://www.gnu.org/licenses/gpl.html
-// AL, Apache License, V2.0 or later, http://www.apache.org/licenses
-// BSD, BSD License, http://www.opensource.org/licenses/bsd-license.php
-//
-// Please contact the author if you need another license.
-// This module is provided "as is", without warranties of any kind.
-
-package org.yaml.snakeyaml.external.biz.base64Coder;
-
-/**
- * A Base64 encoder/decoder.
- *
- * <p>
- * This class is used to encode and decode data in Base64 format as described in RFC 1521.
- *
- * <p>
- * Project home page: <a href="http://www.source-code.biz/base64coder/java/">www.
- * source-code.biz/base64coder/java</a><br>
- * Author: Christian d'Heureuse, Inventec Informatik AG, Zurich, Switzerland<br>
- * Multi-licensed: EPL / LGPL / GPL / AL / BSD.
- */
-public class Base64Coder {
-
-  // The line separator string of the operating system.
-  private static final String systemLineSeparator = System.getProperty("line.separator");
-
-  // Mapping table from 6-bit nibbles to Base64 characters.
-  private static final char[] map1 = new char[64];
-
-  static {
-    int i = 0;
-    for (char c = 'A'; c <= 'Z'; c++) {
-      map1[i++] = c;
-    }
-    for (char c = 'a'; c <= 'z'; c++) {
-      map1[i++] = c;
-    }
-    for (char c = '0'; c <= '9'; c++) {
-      map1[i++] = c;
-    }
-    map1[i++] = '+';
-    map1[i++] = '/';
-  }
-
-  // Mapping table from Base64 characters to 6-bit nibbles.
-  private static final byte[] map2 = new byte[128];
-
-  static {
-    for (int i = 0; i < map2.length; i++) {
-      map2[i] = -1;
-    }
-    for (int i = 0; i < 64; i++) {
-      map2[map1[i]] = (byte) i;
-    }
-  }
-
-  /**
-   * Encodes a string into Base64 format. No blanks or line breaks are inserted.
-   *
-   * @param s A String to be encoded.
-   * @return A String containing the Base64 encoded data.
-   */
-  public static String encodeString(String s) {
-    return new String(encode(s.getBytes()));
-  }
-
-  /**
-   * Encodes a byte array into Base 64 format and breaks the output into lines of 76 characters.
-   * This method is compatible with <code>sun.misc.BASE64Encoder.encodeBuffer(byte[])</code>.
-   *
-   * @param in An array containing the data bytes to be encoded.
-   * @return A String containing the Base64 encoded data, broken into lines.
-   */
-  public static String encodeLines(byte[] in) {
-    return encodeLines(in, 0, in.length, 76, systemLineSeparator);
-  }
-
-  /**
-   * Encodes a byte array into Base 64 format and breaks the output into lines.
-   *
-   * @param in An array containing the data bytes to be encoded.
-   * @param iOff Offset of the first byte in <code>in</code> to be processed.
-   * @param iLen Number of bytes to be processed in <code>in</code>, starting at <code>iOff</code>.
-   * @param lineLen Line length for the output data. Should be a multiple of 4.
-   * @param lineSeparator The line separator to be used to separate the output lines.
-   * @return A String containing the Base64 encoded data, broken into lines.
-   */
-  public static String encodeLines(byte[] in, int iOff, int iLen, int lineLen,
-      String lineSeparator) {
-    int blockLen = (lineLen * 3) / 4;
-    if (blockLen <= 0) {
-      throw new IllegalArgumentException();
-    }
-    int lines = (iLen + blockLen - 1) / blockLen;
-    int bufLen = ((iLen + 2) / 3) * 4 + lines * lineSeparator.length();
-    StringBuilder buf = new StringBuilder(bufLen);
-    int ip = 0;
-    while (ip < iLen) {
-      int l = Math.min(iLen - ip, blockLen);
-      buf.append(encode(in, iOff + ip, l));
-      buf.append(lineSeparator);
-      ip += l;
-    }
-    return buf.toString();
-  }
-
-  /**
-   * Encodes a byte array into Base64 format. No blanks or line breaks are inserted in the output.
-   *
-   * @param in An array containing the data bytes to be encoded.
-   * @return A character array containing the Base64 encoded data.
-   */
-  public static char[] encode(byte[] in) {
-    return encode(in, 0, in.length);
-  }
-
-  /**
-   * Encodes a byte array into Base64 format. No blanks or line breaks are inserted in the output.
-   *
-   * @param in An array containing the data bytes to be encoded.
-   * @param iLen Number of bytes to process in <code>in</code>.
-   * @return A character array containing the Base64 encoded data.
-   */
-  public static char[] encode(byte[] in, int iLen) {
-    return encode(in, 0, iLen);
-  }
-
-  /**
-   * Encodes a byte array into Base64 format. No blanks or line breaks are inserted in the output.
-   *
-   * @param in An array containing the data bytes to be encoded.
-   * @param iOff Offset of the first byte in <code>in</code> to be processed.
-   * @param iLen Number of bytes to process in <code>in</code>, starting at <code>iOff</code>.
-   * @return A character array containing the Base64 encoded data.
-   */
-  public static char[] encode(byte[] in, int iOff, int iLen) {
-    int oDataLen = (iLen * 4 + 2) / 3; // output length without padding
-    int oLen = ((iLen + 2) / 3) * 4; // output length including padding
-    char[] out = new char[oLen];
-    int ip = iOff;
-    int iEnd = iOff + iLen;
-    int op = 0;
-    while (ip < iEnd) {
-      int i0 = in[ip++] & 0xff;
-      int i1 = ip < iEnd ? in[ip++] & 0xff : 0;
-      int i2 = ip < iEnd ? in[ip++] & 0xff : 0;
-      int o0 = i0 >>> 2;
-      int o1 = ((i0 & 3) << 4) | (i1 >>> 4);
-      int o2 = ((i1 & 0xf) << 2) | (i2 >>> 6);
-      int o3 = i2 & 0x3F;
-      out[op++] = map1[o0];
-      out[op++] = map1[o1];
-      out[op] = op < oDataLen ? map1[o2] : '=';
-      op++;
-      out[op] = op < oDataLen ? map1[o3] : '=';
-      op++;
-    }
-    return out;
-  }
-
-  /**
-   * Decodes a string from Base64 format. No blanks or line breaks are allowed within the Base64
-   * encoded input data.
-   *
-   * @param s A Base64 String to be decoded.
-   * @return A String containing the decoded data.
-   * @throws IllegalArgumentException If the input is not valid Base64 encoded data.
-   */
-  public static String decodeString(String s) {
-    return new String(decode(s));
-  }
-
-  /**
-   * Decodes a byte array from Base64 format and ignores line separators, tabs and blanks. CR, LF,
-   * Tab and Space characters are ignored in the input data. This method is compatible with
-   * <code>sun.misc.BASE64Decoder.decodeBuffer(String)</code>.
-   *
-   * @param s A Base64 String to be decoded.
-   * @return An array containing the decoded data bytes.
-   * @throws IllegalArgumentException If the input is not valid Base64 encoded data.
-   */
-  public static byte[] decodeLines(String s) {
-    char[] buf = new char[s.length()];
-    int p = 0;
-    for (int ip = 0; ip < s.length(); ip++) {
-      char c = s.charAt(ip);
-      if (c != ' ' && c != '\r' && c != '\n' && c != '\t') {
-        buf[p++] = c;
-      }
-    }
-    return decode(buf, 0, p);
-  }
-
-  /**
-   * Decodes a byte array from Base64 format. No blanks or line breaks are allowed within the Base64
-   * encoded input data.
-   *
-   * @param s A Base64 String to be decoded.
-   * @return An array containing the decoded data bytes.
-   * @throws IllegalArgumentException If the input is not valid Base64 encoded data.
-   */
-  public static byte[] decode(String s) {
-    return decode(s.toCharArray());
-  }
-
-  /**
-   * Decodes a byte array from Base64 format. No blanks or line breaks are allowed within the Base64
-   * encoded input data.
-   *
-   * @param in A character array containing the Base64 encoded data.
-   * @return An array containing the decoded data bytes.
-   * @throws IllegalArgumentException If the input is not valid Base64 encoded data.
-   */
-  public static byte[] decode(char[] in) {
-    return decode(in, 0, in.length);
-  }
-
-  /**
-   * Decodes a byte array from Base64 format. No blanks or line breaks are allowed within the Base64
-   * encoded input data.
-   *
-   * @param in A character array containing the Base64 encoded data.
-   * @param iOff Offset of the first character in <code>in</code> to be processed.
-   * @param iLen Number of characters to process in <code>in</code>, starting at <code>iOff</code>.
-   * @return An array containing the decoded data bytes.
-   * @throws IllegalArgumentException If the input is not valid Base64 encoded data.
-   */
-  public static byte[] decode(char[] in, int iOff, int iLen) {
-    if (iLen % 4 != 0) {
-      throw new IllegalArgumentException(
-          "Length of Base64 encoded input string is not a multiple of 4.");
-    }
-    while (iLen > 0 && in[iOff + iLen - 1] == '=') {
-      iLen--;
-    }
-    int oLen = (iLen * 3) / 4;
-    byte[] out = new byte[oLen];
-    int ip = iOff;
-    int iEnd = iOff + iLen;
-    int op = 0;
-    while (ip < iEnd) {
-      int i0 = in[ip++];
-      int i1 = in[ip++];
-      int i2 = ip < iEnd ? in[ip++] : 'A';
-      int i3 = ip < iEnd ? in[ip++] : 'A';
-      if (i0 > 127 || i1 > 127 || i2 > 127 || i3 > 127) {
-        throw new IllegalArgumentException("Illegal character in Base64 encoded data.");
-      }
-      int b0 = map2[i0];
-      int b1 = map2[i1];
-      int b2 = map2[i2];
-      int b3 = map2[i3];
-      if (b0 < 0 || b1 < 0 || b2 < 0 || b3 < 0) {
-        throw new IllegalArgumentException("Illegal character in Base64 encoded data.");
-      }
-      int o0 = (b0 << 2) | (b1 >>> 4);
-      int o1 = ((b1 & 0xf) << 4) | (b2 >>> 2);
-      int o2 = ((b2 & 3) << 6) | b3;
-      out[op++] = (byte) o0;
-      if (op < oLen) {
-        out[op++] = (byte) o1;
-      }
-      if (op < oLen) {
-        out[op++] = (byte) o2;
-      }
-    }
-    return out;
-  }
-
-  // Dummy constructor.
-  private Base64Coder() {}
-
-} // end class Base64Coder
diff --git a/src/main/java/org/yaml/snakeyaml/representer/SafeRepresenter.java b/src/main/java/org/yaml/snakeyaml/representer/SafeRepresenter.java
index 889b573c..d524ea4a 100644
--- a/src/main/java/org/yaml/snakeyaml/representer/SafeRepresenter.java
+++ b/src/main/java/org/yaml/snakeyaml/representer/SafeRepresenter.java
@@ -15,22 +15,10 @@ package org.yaml.snakeyaml.representer;
 
 import java.math.BigInteger;
 import java.nio.charset.StandardCharsets;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Calendar;
-import java.util.Date;
-import java.util.HashMap;
-import java.util.Iterator;
-import java.util.LinkedHashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.Set;
-import java.util.TimeZone;
-import java.util.UUID;
+import java.util.*;
 import java.util.regex.Pattern;
 import org.yaml.snakeyaml.DumperOptions;
 import org.yaml.snakeyaml.error.YAMLException;
-import org.yaml.snakeyaml.external.biz.base64Coder.Base64Coder;
 import org.yaml.snakeyaml.nodes.Node;
 import org.yaml.snakeyaml.nodes.Tag;
 import org.yaml.snakeyaml.reader.StreamReader;
@@ -127,8 +115,7 @@ class SafeRepresenter extends BaseRepresenter {
         if (!checkValue.equals(value)) {
           throw new YAMLException("invalid string value has occurred");
         }
-        char[] binary = Base64Coder.encode(bytes);
-        value = String.valueOf(binary);
+        value = Base64.getEncoder().encodeToString(bytes);
         style = DumperOptions.ScalarStyle.LITERAL;
       }
       // if no other scalar style is explicitly set, use literal style for
@@ -449,8 +436,9 @@ class SafeRepresenter extends BaseRepresenter {
   protected class RepresentByteArray implements Represent {
 
     public Node representData(Object data) {
-      char[] binary = Base64Coder.encode((byte[]) data);
-      return representScalar(Tag.BINARY, String.valueOf(binary), DumperOptions.ScalarStyle.LITERAL);
+      String encoded = Base64.getEncoder().encodeToString((byte[]) data);
+      return representScalar(Tag.BINARY, String.valueOf(encoded),
+          DumperOptions.ScalarStyle.LITERAL);
     }
   }
 
diff --git a/src/test/java/biz/source_code/base64Coder/Base64CoderTest.java b/src/test/java/biz/source_code/base64Coder/Base64CoderTest.java
index 295eb729..1bcf0f6c 100644
--- a/src/test/java/biz/source_code/base64Coder/Base64CoderTest.java
+++ b/src/test/java/biz/source_code/base64Coder/Base64CoderTest.java
@@ -15,8 +15,9 @@ package biz.source_code.base64Coder;
 
 import java.io.UnsupportedEncodingException;
 import java.nio.charset.StandardCharsets;
+import java.util.Base64;
+
 import junit.framework.TestCase;
-import org.yaml.snakeyaml.external.biz.base64Coder.Base64Coder;
 
 public class Base64CoderTest extends TestCase {
 
@@ -30,10 +31,10 @@ public class Base64CoderTest extends TestCase {
 
   public void testFailure1() throws UnsupportedEncodingException {
     try {
-      Base64Coder.decode("YQ=".toCharArray());
+      Base64.getDecoder().decode("YQ=");
       fail();
     } catch (Exception e) {
-      assertEquals("Length of Base64 encoded input string is not a multiple of 4.", e.getMessage());
+      assertEquals("Input byte array has wrong 4-byte ending unit", e.getMessage());
     }
   }
 
@@ -51,18 +52,18 @@ public class Base64CoderTest extends TestCase {
 
   private void checkInvalid(String encoded) {
     try {
-      Base64Coder.decode(encoded.toCharArray());
-      fail("Illegal chanracter.");
+      Base64.getDecoder().decode(encoded);
+      fail("Illegal character.");
     } catch (Exception e) {
-      assertEquals("Illegal character in Base64 encoded data.", e.getMessage());
+      assertTrue(e.getMessage().startsWith("Illegal base64 character "));
     }
   }
 
   private void check(String text, String encoded) throws UnsupportedEncodingException {
-    char[] s1 = Base64Coder.encode(text.getBytes(StandardCharsets.UTF_8));
+    byte[] s1 = Base64.getEncoder().encode(text.getBytes());
     String t1 = new String(s1);
     assertEquals(encoded, t1);
-    byte[] s2 = Base64Coder.decode(encoded.toCharArray());
+    byte[] s2 = Base64.getDecoder().decode(encoded);
     String t2 = new String(s2, StandardCharsets.UTF_8);
     assertEquals(text, t2);
   }
diff --git a/src/test/java/org/yaml/snakeyaml/issues/issue99/YamlBase64Test.java b/src/test/java/org/yaml/snakeyaml/issues/issue99/YamlBase64Test.java
index d1fe1f67..220f995e 100644
--- a/src/test/java/org/yaml/snakeyaml/issues/issue99/YamlBase64Test.java
+++ b/src/test/java/org/yaml/snakeyaml/issues/issue99/YamlBase64Test.java
@@ -16,6 +16,7 @@ package org.yaml.snakeyaml.issues.issue99;
 import java.io.BufferedInputStream;
 import java.io.IOException;
 import java.io.InputStream;
+import java.util.Base64;
 import java.util.Map;
 import junit.framework.TestCase;
 import org.yaml.snakeyaml.LoaderOptions;
@@ -24,7 +25,6 @@ import org.yaml.snakeyaml.Yaml;
 import org.yaml.snakeyaml.YamlDocument;
 import org.yaml.snakeyaml.constructor.AbstractConstruct;
 import org.yaml.snakeyaml.constructor.Constructor;
-import org.yaml.snakeyaml.external.biz.base64Coder.Base64Coder;
 import org.yaml.snakeyaml.nodes.Node;
 import org.yaml.snakeyaml.nodes.ScalarNode;
 import org.yaml.snakeyaml.nodes.Tag;
@@ -47,12 +47,11 @@ public class YamlBase64Test extends TestCase {
       all = all + lines[i].trim();
     }
     // System.out.println(all);
-    byte[] decoded = Base64Coder.decode(all.toCharArray());
+    byte[] decoded = Base64.getDecoder().decode(all);
     assertEquals(3737, decoded.length);
     checkBytes(decoded);
   }
 
-  @SuppressWarnings("unchecked")
   public void testYamlBase64Loading() throws IOException {
     Yaml yaml = new Yaml();
     InputStream inputStream =
@@ -122,7 +121,7 @@ public class YamlBase64Test extends TestCase {
       public Object construct(Node node) {
         String contentWithNewLines = constructScalar((ScalarNode) node);
         String noNewLines = contentWithNewLines.replaceAll("\\s", "");
-        byte[] decoded = Base64Coder.decode(noNewLines.toCharArray());
+        byte[] decoded = Base64.getDecoder().decode(noNewLines);
         return decoded;
       }
     }
@@ -131,7 +130,6 @@ public class YamlBase64Test extends TestCase {
   /**
    * Define a local tag to ignore all the white spaces to be able to use literal scalar
    */
-  @SuppressWarnings("unchecked")
   public void testLocalBinaryTag() throws IOException {
     Yaml yaml = new Yaml(new SpecialContructor(new Tag("!beautiful")));
     InputStream inputStream =
-- 
2.44.0

Places

File 0001-Remove-external-Base64Coder-and-use-provided-Base64.patch of Package snakeyaml (Revision cef6397f01ba432db9e15e603763bac2)

Places