File libbpf-Fix-null-pointer-dereference-in-find_pro... of Package libbpf

Overview Repositories Revisions Requests Users Attributes Meta

File libbpf-Fix-null-pointer-dereference-in-find_prog_by_.patch of Package libbpf (Revision 1cedbd9be0c0e36f034b6dad97421383)

Currently displaying revision 1cedbd9be0c0e36f034b6dad97421383 , Show latest

From 3a3ef0c1d09e1894740db71cdcb7be0bfd713671 Mon Sep 17 00:00:00 2001
From: Shung-Hsi Yu <shung-hsi.yu@suse.com>
Date: Wed, 12 Oct 2022 10:23:53 +0800
Subject: [PATCH 4/4] libbpf: Fix null-pointer dereference in
 find_prog_by_sec_insn()

When there are no program sections, obj->programs is left unallocated,
and find_prog_by_sec_insn()'s search lands on &obj->programs[0] == NULL,
and will cause null-pointer dereference in the following access to
prog->sec_idx.

Guard the search with obj->nr_programs similar to what's being done in
__bpf_program__iter() to prevent null-pointer access from happening.

Fixes: db2b8b06423c ("libbpf: Support CO-RE relocations for multi-prog sections")
Signed-off-by: Shung-Hsi Yu <shung-hsi.yu@suse.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20221012022353.7350-4-shung-hsi.yu@suse.com
---
 src/libbpf.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/libbpf.c b/src/libbpf.c
index 29e9df0..8c3f236 100644
--- a/src/libbpf.c
+++ b/src/libbpf.c
@@ -4115,6 +4115,9 @@ static struct bpf_program *find_prog_by_sec_insn(const struct bpf_object *obj,
 	int l = 0, r = obj->nr_programs - 1, m;
 	struct bpf_program *prog;
 
+	if (!obj->nr_programs)
+		return NULL;
+
 	while (l < r) {
 		m = l + (r - l + 1) / 2;
 		prog = &obj->programs[m];
-- 
2.38.0

Places

File libbpf-Fix-null-pointer-dereference-in-find_prog_by_.patch of Package libbpf (Revision 1cedbd9be0c0e36f034b6dad97421383)

Places