File ruby-1.8.7_safe_level_bypass.patch of Package ruby.1051

Overview Repositories Revisions Requests Users Attributes Meta

File ruby-1.8.7_safe_level_bypass.patch of Package ruby.1051

Index: error.c
===================================================================
--- error.c.orig	2011-02-18 13:32:35.000000000 +0100
+++ error.c	2012-10-25 18:33:25.395358772 +0200
@@ -665,9 +665,6 @@ name_err_to_s(exc)
 
     if (NIL_P(mesg)) return rb_class_name(CLASS_OF(exc));
     StringValue(str);
-    if (str != mesg) {
-	OBJ_INFECT(str, mesg);
-    }
     return str;
 }
 
Index: test/ruby/test_exception.rb
===================================================================
--- test/ruby/test_exception.rb.orig	2011-02-18 13:32:35.000000000 +0100
+++ test/ruby/test_exception.rb	2012-10-25 18:33:25.396358773 +0200
@@ -206,4 +206,54 @@ class TestException < Test::Unit::TestCa
     s = e.to_s
     assert_equal(true, s.tainted?)
   end
+
+  def test_to_s_taintness_propagation
+    for exc in [Exception, NameError]
+      m = "abcdefg"
+      e = exc.new(m)
+      e.taint
+      s = e.to_s
+      assert_equal(false, m.tainted?,
+                   "#{exc}#to_s should not propagate taintness")
+      assert_equal(false, s.tainted?,
+                   "#{exc}#to_s should not propagate taintness")
+    end
+
+    o = Object.new
+    def o.to_str
+      "foo"
+    end
+    o.taint
+    e = NameError.new(o)
+    s = e.to_s
+    assert_equal(false, s.tainted?)
+  end
+
+  def test_exception_to_s_should_not_propagate_untrustedness
+    favorite_lang = "Ruby"
+
+    for exc in [Exception, NameError]
+      assert_raise(SecurityError) do
+        lambda {
+          $SAFE = 4
+          exc.new(favorite_lang).to_s
+          favorite_lang.replace("Python")
+        }.call
+      end
+    end
+
+    assert_raise(SecurityError) do
+      lambda {
+        $SAFE = 4
+        o = Object.new
+        (class << o; self; end).send(:define_method, :to_str) {
+          favorite_lang
+        }
+        NameError.new(o).to_s
+        favorite_lang.replace("Python")
+      }.call
+    end
+
+    assert_equal("Ruby", favorite_lang)
+  end
 end

Places

File ruby-1.8.7_safe_level_bypass.patch of Package ruby.1051

Places